Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS AI Chat - Improve show/dismiss animation #3741

Merged
merged 8 commits into from
Dec 20, 2024
Merged

iOS AI Chat - Improve show/dismiss animation #3741

merged 8 commits into from
Dec 20, 2024

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Dec 18, 2024

Task/Issue URL: https://app.asana.com/0/1204167627774280/1208991512395325/f

Description:
Allow user to drag the AI Chat view controller down by the title bar

Steps to test this PR:

  1. Make yourself internal user
  2. Open AI Chat
  3. Dismiss is by tapping the X button
  4. Dismiss it by dragging it down from the titlebar

@Bunn Bunn requested a review from jotaemepereira December 18, 2024 20:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against ab77bb4

jotaemepereira
jotaemepereira approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the dismissal and it works as expected 👍🏼 .

@Bunn Bunn merged commit 1411032 into main Dec 20, 2024
14 checks passed
@Bunn Bunn deleted the bunn/aichat/pull branch December 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotaemepereira jotaemepereira jotaemepereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @jotaemepereira