Skip to content
This repository has been archived by the owner on Feb 24, 2025. It is now read-only.

Aligning Privacy Dashboard EventMapping with macOS #3822

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Aligning Privacy Dashboard EventMapping with macOS #3822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc8f1d2
Remove experiment code
jaceklyp Nov 8, 2024
67343f5
Not firing reportBrokenSiteShown automatically
jaceklyp Nov 8, 2024
bef0bb0
BSK update
mgurgel Jan 17, 2025
2469026
BSK update
mgurgel Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11952,7 +11952,7 @@
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
branch = "mgurgel/improved-breakage-form";
branch = "mgurgel/improved-breakage-form-pixel";
kind = branch;
};
};
Expand Down
8 changes: 4 additions & 4 deletions DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
"state" : {
"branch" : "mgurgel/improved-breakage-form",
"revision" : "c77e36efe790bc01af9b152fc0ef0fbb35a32f82"
"branch" : "mgurgel/improved-breakage-form-pixel",
"revision" : "f85a4199ba4251921ecff6d110527c8d5c44e329"
}
},
{
Expand Down Expand Up @@ -122,8 +122,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/privacy-dashboard",
"state" : {
"revision" : "3f58e008d4e9d1b56ab12dbb95bd891045cf2758",
"version" : "8.0.0"
"branch" : "pr-releases/pr-302",
"revision" : "05d04de7505117b32949b2007e5a56ba2d39469b"
}
},
{
Expand Down
11 changes: 0 additions & 11 deletions DuckDuckGo/MainViewController+Segues.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,6 @@ extension MainViewController {
return
}

if entryPoint == .report {
fireBrokenSiteReportShown()
}

let storyboard = UIStoryboard(name: "PrivacyDashboard", bundle: nil)
let controller = storyboard.instantiateInitialViewController { coder in
PrivacyDashboardViewController(coder: coder,
Expand Down Expand Up @@ -141,13 +137,6 @@ extension MainViewController {
present(controller, animated: true)
}

private func fireBrokenSiteReportShown() {
let parameters = [
PrivacyDashboardEvents.Parameters.source: BrokenSiteReport.Source.appMenu.rawValue
]
Pixel.fire(pixel: .reportBrokenSiteShown, withAdditionalParameters: parameters)
}

func segueToNegativeFeedbackForm() {
Logger.lifecycle.debug(#function)
hideAllHighlightsIfNeeded()
Expand Down
Loading