Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip patch component from the OS version in Pixel requests User Agent #3898

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Strip patch component from the OS version in Pixel requests User Agent #3898

merged 1 commit into from
Jan 30, 2025

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jan 30, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1209268316380789/f

Description:
This change updates how we pass OS version in Pixel requests, as agreed in the Privacy Triage.

Steps to test this PR:

  1. Update Launching.swift:128 (Pixel.isDryRun) and set dryRun to false.
  2. Set a breakpoint in Pixel.swift:285 (request.fetch) and run the app.
  3. When stopped at the breakpoint, inspect request and verify that the User Agent header only contains OS version without the patch component.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy requested a review from aataraxiaa January 30, 2025 10:33
aataraxiaa
aataraxiaa approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Note that some CI checks are failing.

@ayoy ayoy merged commit f617e2b into main Jan 30, 2025
16 of 20 checks passed
@ayoy ayoy deleted the dominik/update-default-ua branch January 30, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aataraxiaa aataraxiaa aataraxiaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayoy @aataraxiaa