Skip to content
PR Checks

Freemium PIR: Refactor Freemium PIR State to Remove Dependency on AccountManager #12284

Sign in to view logs

Freemium PIR: Refactor Freemium PIR State to Remove Dependency on AccountManager

Freemium PIR: Refactor Freemium PIR State to Remove Dependency on AccountManager #12284

Triggered via pull request September 4, 2024 08:38
@aataraxiaaaataraxiaa
synchronize #3197
pete/feature/pir-freemium-state-improvement
Status Failure
Total duration 12m 22s
Billable time 31m
Artifacts –

pr.yml

on: pull_request
Matrix: Test
SwiftLint
39s
SwiftLint
Test Shell Scripts
18s
Test Shell Scripts
Make Release Build
7m 54s
Make Release Build
Verify autoconsent bundle
0s
Verify autoconsent bundle
ShellCheck
11s
ShellCheck
Private API Report  /  Update PR comment
2s
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

7 errors, 32 warnings, and 1 notice
SwiftLint: DuckDuckGo/HomePage/View/HomePageViewController.swift#L220
TODOs should be resolved (Remove this) (todo)
SwiftLint: DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift#L263
TODOs should be resolved (Remove this) (todo)
SwiftLint: DuckDuckGo/Freemium/PIR/FreemiumPIRPresenter.swift#L41
TODOs should be resolved (- Onboard (i.e Ts and Cs)) (todo)
SwiftLint: DuckDuckGo/Freemium/PIR/FreemiumPIRPresenter.swift#L51
TODOs should be resolved (- Show onboarding if we decide...) (todo)
SwiftLint: DuckDuckGo/Freemium/PIR/FreemiumPIRFeature.swift#L46
TODOs should be resolved (- Also check experiment cohort...) (todo)
Test (Non-Sandbox): IntegrationTests/PrivacyDashboard/PrivacyDashboardIntegrationTests.swift#L72
testWhenTrackerDetected_trackerInfoUpdated, failed: caught error: "Timeout"
Test (Sandbox): IntegrationTests/PrivacyDashboard/PrivacyDashboardIntegrationTests.swift#L72
testWhenTrackerDetected_trackerInfoUpdated, failed: caught error: "Timeout"
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Storage/DataBrokerProtectionKeyStoreProvider.swift#L60
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Storage/DataBrokerProtectionKeyStoreProvider.swift#L61
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Storage/DataBrokerProtectionKeyStoreProvider.swift#L67
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L27
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L27
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L30
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L30
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L33
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L33
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L36
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Storage/DataBrokerProtectionKeyStoreProvider.swift#L60
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Storage/DataBrokerProtectionKeyStoreProvider.swift#L61
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Storage/DataBrokerProtectionKeyStoreProvider.swift#L67
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L27
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L27
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L30
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L30
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L33
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L33
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/Logging.swift#L36
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Sandbox): DuckDuckGo/FileDownload/Model/FilePresenter.swift#L35
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Sandbox): DuckDuckGo/FileDownload/Model/FilePresenter.swift#L158
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Sandbox): DuckDuckGo/FileDownload/Model/FilePresenter.swift#L179
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Sandbox): DuckDuckGo/FileDownload/Model/FilePresenter.swift#L348
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Sandbox): DuckDuckGo/FileDownload/Model/FilePresenter.swift#L370
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Sandbox): DuckDuckGo/FileDownload/Model/FilePresenter.swift#L384
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Sandbox): sandbox-test-tool/SandboxTestTool.swift#L99
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Sandbox): DuckDuckGo/FileDownload/Model/SecurityScopedFileURLController.swift#L45
'OSLog' is deprecated: Use Logger.yourFeature instead, see https://app.asana.com/0/1202500774821704/1208001254061393/f
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel