Bookmarks undo deletion #13033
mallexxxpr.yml
on: pull_request
Matrix: Test
SwiftLint
43s
Test Shell Scripts
18s
Make Release Build
9m 17s
Verify autoconsent bundle
0s
ShellCheck
6s
Annotations
21 errors and 37 warnings
|
SwiftLint:
DuckDuckGo/Bookmarks/Model/BookmarkManager.swift#L356
Unused parameter in a closure should be replaced with _ (unused_closure_parameter)
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L761
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsDifferentFromOriginalFolderAndModeIsEdit, XCTAssertTrue failed
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L762
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsDifferentFromOriginalFolderAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(["1"])")
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L763
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsDifferentFromOriginalFolderAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(DuckDuckGo_Privacy_Browser.ParentFolderType.parent(uuid: "ABCDE"))")
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L788
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsNilAndOriginalFolderIsNotRootFolderAndModeIsEdit, XCTAssertTrue failed
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L789
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsNilAndOriginalFolderIsNotRootFolderAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(["1"])")
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L790
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsNilAndOriginalFolderIsNotRootFolderAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(DuckDuckGo_Privacy_Browser.ParentFolderType.root)")
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L684
testShouldAskBookmarkStoreToUpdateBookmarkWhenIsFavoriteIsUpdatedAndModeIsEdit, XCTAssertTrue failed
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L685
testShouldAskBookmarkStoreToUpdateBookmarkWhenIsFavoriteIsUpdatedAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(<Bookmark⭐️ 1 title: "testShouldAskBookmarkStoreToUpdateBookmarkWhenIsFavoriteIsUpdatedAndModeIsEdit()" url: "https://duckduckgo.com/" parent: root>)")
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L560
testShouldAskBookmarkStoreToUpdateBookmarkWhenModeIsAddAndURLIsAnExistingBookmark, XCTAssertEqual failed: ("nil") is not equal to ("Optional("testShouldAskBookmarkStoreToUpdateBookmarkWhenModeIsAddAndURLIsAnExistingBookmark()")")
|
|
Test (Non-Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L561
testShouldAskBookmarkStoreToUpdateBookmarkWhenModeIsAddAndURLIsAnExistingBookmark, XCTAssertEqual failed: ("nil") is not equal to ("Optional("https://duckduckgo.com/")")
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L761
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsDifferentFromOriginalFolderAndModeIsEdit, XCTAssertTrue failed
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L762
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsDifferentFromOriginalFolderAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(["1"])")
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L763
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsDifferentFromOriginalFolderAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(DuckDuckGo_Privacy_Browser.ParentFolderType.parent(uuid: "ABCDE"))")
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L788
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsNilAndOriginalFolderIsNotRootFolderAndModeIsEdit, XCTAssertTrue failed
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L789
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsNilAndOriginalFolderIsNotRootFolderAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(["1"])")
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L790
testShouldAskBookmarkStoreToMoveBookmarkWhenSelectedFolderIsNilAndOriginalFolderIsNotRootFolderAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(DuckDuckGo_Privacy_Browser.ParentFolderType.root)")
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L684
testShouldAskBookmarkStoreToUpdateBookmarkWhenIsFavoriteIsUpdatedAndModeIsEdit, XCTAssertTrue failed
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L685
testShouldAskBookmarkStoreToUpdateBookmarkWhenIsFavoriteIsUpdatedAndModeIsEdit, XCTAssertEqual failed: ("nil") is not equal to ("Optional(<Bookmark⭐️ 1 title: "testShouldAskBookmarkStoreToUpdateBookmarkWhenIsFavoriteIsUpdatedAndModeIsEdit()" url: "https://duckduckgo.com/" parent: root>)")
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L560
testShouldAskBookmarkStoreToUpdateBookmarkWhenModeIsAddAndURLIsAnExistingBookmark, XCTAssertEqual failed: ("nil") is not equal to ("Optional("testShouldAskBookmarkStoreToUpdateBookmarkWhenModeIsAddAndURLIsAnExistingBookmark()")")
|
|
Test (Sandbox):
UnitTests/Bookmarks/ViewModels/AddEditBookmarkDialogViewModelTests.swift#L561
testShouldAskBookmarkStoreToUpdateBookmarkWhenModeIsAddAndURLIsAnExistingBookmark, XCTAssertEqual failed: ("nil") is not equal to ("Optional("https://duckduckgo.com/")")
|
|
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Make Release Build:
DerivedData/Build/Products/Release/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-integrationtests-xcodebuild.log. No artifacts will be uploaded.
|
|
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-integrationtests.xcresult. No artifacts will be uploaded.
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L327
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test (Sandbox)
No files were found with the provided path: Sandbox-integrationtests-xcodebuild.log. No artifacts will be uploaded.
|
|
Test (Sandbox)
No files were found with the provided path: Sandbox-integrationtests.xcresult. No artifacts will be uploaded.
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Test (Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Test (Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Test (Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
Non-Sandbox-unittests-xcodebuild.log
Expired
|
827 KB |
|
|
Non-Sandbox-unittests.xcresult
Expired
|
91.4 MB |
|
|
Sandbox-unittests-xcodebuild.log
Expired
|
1.34 MB |
|
|
Sandbox-unittests.xcresult
Expired
|
89.9 MB |
|