Skip to content
Danger JS

BookmarkManager minor improvements #12134

Sign in to view logs

BookmarkManager minor improvements

BookmarkManager minor improvements #12134

Triggered via pull request October 5, 2024 09:47
@mallexxxmallexxx
synchronize #3300
alex/bookmarks-minor-improvements
Status Success
Total duration 1m 42s
Artifacts –

danger.yml

on: pull_request
Danger JS
1m 32s
Danger JS
Fit to window
Zoom out
Zoom in

Annotations

14 errors
AddEditBookmarkFolderDialogViewModelTests.testShouldAskBookmarkStoreToSaveFolderWhenAddOrSaveIsCalledAndModeIsAdd: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Bookmarks/ViewModels/AddEditBookmarkFolderDialogViewModelTests.swift:360 - XCTAssertEqual failed: ("nil") is not equal to ("Optional("testShouldAskBookmarkStoreToSaveFolderWhenAddOrSaveIsCalledAndModeIsAdd()")")
AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToNilWhenParentFolderIsNilAndModeIsAdd: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
Restarting after unexpected exit, crash, or test timeout in AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToNilWhenParentFolderIsNilAndModeIsAdd(); summary will include totals from previous launches.
AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToNilWhenParentFolderIsNilAndModeIsEdit: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
Restarting after unexpected exit, crash, or test timeout in AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToNilWhenParentFolderIsNilAndModeIsEdit(); summary will include totals from previous launches.
AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToValueWhenParentFolderIsNotNilAndModeIsAdd: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
Restarting after unexpected exit, crash, or test timeout in AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToValueWhenParentFolderIsNotNilAndModeIsAdd(); summary will include totals from previous launches.
AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToValueWhenParentFolderIsNotNilAndModeIsEdit: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
Restarting after unexpected exit, crash, or test timeout in AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToValueWhenParentFolderIsNotNilAndModeIsEdit(); summary will include totals from previous launches.
BookmarkAllTabsDialogViewModelTests.testWhenFolderIsAddedThenFoldersListIsRefreshed: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/BookmarkAllTabsDialogViewModelTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Bookmarks/ViewModels/BookmarkAllTabsDialogViewModelTests.swift:281 - XCTAssertEqual failed: ("3") is not equal to ("2")
LocalBookmarkStoreTests.testWhenMovingBookmarkWithinParentCollection_AndThereAreStubs_ThenIndexIsCalculatedAndBookmarkIsMoved: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/LocalBookmarkStoreTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:537 - XCTAssertEqual failed: ("[Optional("Example 3"), Optional("Example 1"), Optional("Example 4"), Optional("Example 2")]") is not equal to ("[Optional("Example 3"), Optional("Example 1"), Optional("Example 2"), Optional("Example 4")]")
AddEditBookmarkFolderDialogViewModelTests.testShouldAskBookmarkStoreToSaveFolderWhenAddOrSaveIsCalledAndModeIsAdd: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Bookmarks/ViewModels/AddEditBookmarkFolderDialogViewModelTests.swift:360 - XCTAssertEqual failed: ("nil") is not equal to ("Optional("testShouldAskBookmarkStoreToSaveFolderWhenAddOrSaveIsCalledAndModeIsAdd()")")
AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToNilWhenParentFolderIsNilAndModeIsAdd: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
Restarting after unexpected exit, crash, or test timeout in AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToNilWhenParentFolderIsNilAndModeIsAdd(); summary will include totals from previous launches.
AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToNilWhenParentFolderIsNilAndModeIsEdit: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
Restarting after unexpected exit, crash, or test timeout in AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToNilWhenParentFolderIsNilAndModeIsEdit(); summary will include totals from previous launches.
AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToValueWhenParentFolderIsNotNilAndModeIsAdd: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
Restarting after unexpected exit, crash, or test timeout in AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToValueWhenParentFolderIsNotNilAndModeIsAdd(); summary will include totals from previous launches.
AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToValueWhenParentFolderIsNotNilAndModeIsEdit: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/AddEditBookmarkFolderDialogViewModelTests.d#L1
Restarting after unexpected exit, crash, or test timeout in AddEditBookmarkFolderDialogViewModelTests.testShouldSetSelectedFolderToValueWhenParentFolderIsNotNilAndModeIsEdit(); summary will include totals from previous launches.
BookmarkAllTabsDialogViewModelTests.testWhenFolderIsAddedThenFoldersListIsRefreshed: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/BookmarkAllTabsDialogViewModelTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Bookmarks/ViewModels/BookmarkAllTabsDialogViewModelTests.swift:281 - XCTAssertEqual failed: ("3") is not equal to ("2")
LocalBookmarkStoreTests.testWhenMovingBookmarkWithinParentCollection_AndThereAreStubs_ThenIndexIsCalculatedAndBookmarkIsMoved: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/LocalBookmarkStoreTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:537 - XCTAssertEqual failed: ("[Optional("Example 3"), Optional("Example 1"), Optional("Example 4"), Optional("Example 2")]") is not equal to ("[Optional("Example 3"), Optional("Example 1"), Optional("Example 2"), Optional("Example 4")]")