Skip to content
PR Checks

Ship review improvements #8963

Sign in to view logs

Ship review improvements

Ship review improvements #8963

Triggered via pull request March 22, 2024 21:54
@diegoreymendezdiegoreymendez
synchronize #2488
diego/re-register-xpc-checks
Status Failure
Total duration 5m 12s
Billable time 24m
Artifacts 2

pr.yml

on: pull_request
Matrix: Test
Matrix: Make Release Build
SwiftLint
59s
SwiftLint
Verify autoconsent bundle
12s
Verify autoconsent bundle
ShellCheck
6s
ShellCheck
Private API Report  /  Update PR comment
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

4 errors, 46 warnings, and 1 notice
Test (Non-Sandbox)
Restarting after unexpected exit, crash, or test timeout in PinnedTabsManagerTests.testWhenSetUpIsCalledThenPinnedTabsArePopulatedWithCollectionContents(); summary will include totals from previous launches.
Test (Non-Sandbox)
Process completed with exit code 1.
Test (Sandbox)
The job was canceled because "Non-Sandbox" failed.
Test (Sandbox)
The operation was canceled.
Verify autoconsent bundle
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test (Non-Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test (Non-Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox)
not stripping binary because it is signed: /Users/runner/work/macos-browser/macos-browser/DerivedData/SourcePackages/artifacts/grdb.swift/GRDB/GRDB.xcframework/macos-arm64_x86_64/GRDB.framework/Versions/A/GRDB (in target 'DataBrokerProtectionTests' from project 'DataBrokerProtection')
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/NetworkProtectionAppEvents.swift#L87
result of call to 'hasEntitlement(for:cachePolicy:)' is unused
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/AppTargets/DeveloperIDTarget/NetworkProtectionSubscriptionEventHandler.swift#L55
immutable value 'error' was never used; consider replacing with '_' or removing it
Test (Non-Sandbox): UnitTests/HomePage/ContinueSetUpModelTests.swift#L203
variable 'randomGenerator' was never mutated; consider changing to 'let' constant
Test (Non-Sandbox)
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-integrationtests-xcodebuild.log. No artifacts will be uploaded.
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-integrationtests.xcresult. No artifacts will be uploaded.
Make Release Build (DuckDuckGo Privacy Pro)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Make Release Build (DuckDuckGo Privacy Pro): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
Make Release Build (DuckDuckGo Privacy Pro): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
Make Release Build (DuckDuckGo Privacy Pro): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Pro): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Pro): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Pro): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Pro): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/NetworkProtection/AppTargets/DeveloperIDTarget/NetworkProtectionSubscriptionEventHandler.swift#L55
immutable value 'error' was never used; consider replacing with '_' or removing it
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/NetworkProtectionAppEvents.swift#L87
result of call to 'hasEntitlement(for:cachePolicy:)' is unused
Make Release Build (DuckDuckGo Privacy Pro): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Browser)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Make Release Build (DuckDuckGo Privacy Browser): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
Make Release Build (DuckDuckGo Privacy Browser): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
Make Release Build (DuckDuckGo Privacy Browser): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Browser): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Browser): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Browser): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Browser): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/NetworkProtection/AppTargets/DeveloperIDTarget/NetworkProtectionSubscriptionEventHandler.swift#L55
immutable value 'error' was never used; consider replacing with '_' or removing it
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/NetworkProtectionAppEvents.swift#L87
result of call to 'hasEntitlement(for:cachePolicy:)' is unused
Make Release Build (DuckDuckGo Privacy Browser): DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
Test (Sandbox): LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox)
Tests Passed: 0 failed, 0 skipped, 231 total (12.133 seconds)

Artifacts

Produced during runtime
Name Size
Non-Sandbox-unittests-xcodebuild.log Expired
658 KB
Non-Sandbox-unittests.xcresult Expired
75.9 MB