Change how subscriptionFeatureAvailability.isFeatureAvailable is used #8968
pr.yml
on: pull_request
Annotations
3 errors, 45 warnings, and 2 notices
SwiftLint:
DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift#L341
Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
|
Test (Sandbox):
UnitTests/TabExtensionsTests/TabSnapshotExtensionTests.swift#L108
testWhenSnapshotIsNotRestored_ThenRenderingIsTriggeredAfterLoading, XCTAssertEqual failed: ("nil") is not equal to ("Optional(<NSImage 0x600003840140 Size={0, 0} RepProvider=(null)>)")
|
Test (Sandbox)
Process completed with exit code 1.
|
Verify autoconsent bundle
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Make Release Build (DuckDuckGo Privacy Pro)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Make Release Build (DuckDuckGo Privacy Pro):
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
|
Make Release Build (DuckDuckGo Privacy Pro):
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Pro)
Skipping duplicate build file in Compile Sources build phase: /Users/runner/work/macos-browser/macos-browser/DuckDuckGo/Preferences/View/PreferencesDataClearingView.swift (in target 'DuckDuckGo Privacy Pro' from project 'DuckDuckGo')
|
Make Release Build (DuckDuckGo Privacy Pro)
Skipping duplicate build file in Compile Sources build phase: /Users/runner/work/macos-browser/macos-browser/DuckDuckGo/Preferences/View/PreferencesDataClearingView.swift (in target 'DuckDuckGo Privacy Pro' from project 'DuckDuckGo')
|
Make Release Build (DuckDuckGo Privacy Browser)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Make Release Build (DuckDuckGo Privacy Browser):
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
|
Make Release Build (DuckDuckGo Privacy Browser):
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Test (Non-Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Test (Non-Sandbox):
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Test (Non-Sandbox)
not stripping binary because it is signed: /Users/runner/work/macos-browser/macos-browser/DerivedData/SourcePackages/artifacts/grdb.swift/GRDB/GRDB.xcframework/macos-arm64_x86_64/GRDB.framework/Versions/A/GRDB (in target 'DataBrokerProtectionTests' from project 'DataBrokerProtection')
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Test (Non-Sandbox):
UnitTests/HomePage/ContinueSetUpModelTests.swift#L203
variable 'randomGenerator' was never mutated; consider changing to 'let' constant
|
Test (Non-Sandbox)
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
DuckDuckGo Privacy Browser isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser' from project 'DuckDuckGo')
|
Test (Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Test (Sandbox)
No files were found with the provided path: Sandbox-integrationtests-xcodebuild.log. No artifacts will be uploaded.
|
Test (Sandbox)
No files were found with the provided path: Sandbox-integrationtests.xcresult. No artifacts will be uploaded.
|
Test (Sandbox):
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
|
Test (Sandbox):
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
|
Test (Sandbox):
UnitTests/HomePage/ContinueSetUpModelTests.swift#L203
variable 'randomGenerator' was never mutated; consider changing to 'let' constant
|
Test (Sandbox):
UnitTests/HomePage/ContinueSetUpModelTests.swift#L203
variable 'randomGenerator' was never mutated; consider changing to 'let' constant
|
Test (Sandbox)
DuckDuckGoDBPBackgroundAgentAppStore isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgentAppStore' from project 'DuckDuckGo')
|
Test (Sandbox)
DuckDuckGo Privacy Browser App Store isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser App Store' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
Tests Passed: 0 failed, 0 skipped, 231 total (11.673 seconds)
|
Test (Sandbox)
Tests Passed: 0 failed, 0 skipped, 20 total (0.539 seconds)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
Sandbox-unittests-xcodebuild.log
Expired
|
1.03 MB |
|
Sandbox-unittests.xcresult
Expired
|
75.8 MB |
|