Ship review improvements #8983
Annotations
15 warnings and 1 notice
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Build and run unit tests:
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerRunCustomJSONViewModel.swift#L190
instance method 'wait' is unavailable from asynchronous contexts; Await a Task handle instead; this is an error in Swift 6
|
|
Build and run unit tests:
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Build and run unit tests:
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Build and run unit tests:
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Build and run unit tests:
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Build and run unit tests
not stripping binary because it is signed: /Users/runner/work/macos-browser/macos-browser/DerivedData/SourcePackages/artifacts/grdb.swift/GRDB/GRDB.xcframework/macos-arm64_x86_64/GRDB.framework/Versions/A/GRDB (in target 'DataBrokerProtectionTests' from project 'DataBrokerProtection')
|
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/AppTargets/DeveloperIDTarget/NetworkProtectionSubscriptionEventHandler.swift#L55
immutable value 'error' was never used; consider replacing with '_' or removing it
|
|
Build and run unit tests:
UnitTests/HomePage/ContinueSetUpModelTests.swift#L203
variable 'randomGenerator' was never mutated; consider changing to 'let' constant
|
|
Build and run unit tests
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
|
|
Build and run unit tests
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
|
|
Run integration tests
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
|
|
Run integration tests
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
|
|
Run integration tests
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
|
|
Run integration tests
DuckDuckGo Privacy Browser isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser' from project 'DuckDuckGo')
|
|
Build and run unit tests
Tests Passed: 0 failed, 0 skipped, 231 total (12.559 seconds)
|
Loading