Skip to content

Commit

Permalink
Fix NetP privacy policy string key (#1840)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1199230911884351/1205935035854499/f
Tech Design URL:
CC:

**Description**:

This PR fixes a NetP privacy policy string key issue, where we had two
strings with the same key.
  • Loading branch information
samsymons authored Nov 13, 2023
1 parent 3e2fd91 commit 20d7f2d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
10 changes: 5 additions & 5 deletions DuckDuckGo/Common/Localizables/UserText+NetworkProtection.swift
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,13 @@ extension UserText {
static let networkProtectionPrivacyPolicySection2List = NSLocalizedString("network-protection.privacy-policy.section.2.list", value: "That means we have no way to tie what you do online to you as an individual and we don’t have any record of things like:\n • Website visits\n • DNS requests\n • Connections made\n • IP addresses used\n • Session lengths", comment: "Privacy Policy list for Network Protection")

static let networkProtectionPrivacyPolicySection3Title = NSLocalizedString("network-protection.privacy-policy.section.3.title", value: "We only keep anonymous performance metrics that we cannot connect to your online activity.", comment: "Privacy Policy title for Network Protection")
static let networkProtectionPrivacyPolicySection3List = NSLocalizedString("network-protection.privacy-policy.section.3.title", value: "Our servers store generic usage (for example, CPU load) and diagnostic data (for example, errors), but none of that data is connected to any individual’s activity.\n\nWe use this non-identifying information to monitor and ensure the performance and quality of the service, for example to make sure servers aren’t overloaded.", comment: "Privacy Policy list for Network Protection")
static let networkProtectionPrivacyPolicySection3List = NSLocalizedString("network-protection.privacy-policy.section.3.list", value: "Our servers store generic usage (for example, CPU load) and diagnostic data (for example, errors), but none of that data is connected to any individual’s activity.\n\nWe use this non-identifying information to monitor and ensure the performance and quality of the service, for example to make sure servers aren’t overloaded.", comment: "Privacy Policy list for Network Protection")

static let networkProtectionPrivacyPolicySection4Title = NSLocalizedString("network-protection.privacy-policy.section.4.title", value: "We use dedicated servers for all VPN traffic.", comment: "Privacy Policy title for Network Protection")
static let networkProtectionPrivacyPolicySection4List = NSLocalizedString("network-protection.privacy-policy.section.4.title", value: "Dedicated servers means they are not shared with anyone else.\n\nWe rent our servers from providers we carefully selected because they meet our privacy requirements.\n\nWe have strict access controls in place so that only limited DuckDuckGo team members have access to our servers.", comment: "Privacy Policy list for Network Protection")
static let networkProtectionPrivacyPolicySection4List = NSLocalizedString("network-protection.privacy-policy.section.4.list", value: "Dedicated servers means they are not shared with anyone else.\n\nWe rent our servers from providers we carefully selected because they meet our privacy requirements.\n\nWe have strict access controls in place so that only limited DuckDuckGo team members have access to our servers.", comment: "Privacy Policy list for Network Protection")

static let networkProtectionPrivacyPolicySection5Title = NSLocalizedString("network-protection.privacy-policy.section.5.title", value: "We protect and limit use of your data when you communicate directly with DuckDuckGo.", comment: "Privacy Policy title for Network Protection")
static let networkProtectionPrivacyPolicySection5List = NSLocalizedString("network-protection.privacy-policy.section.5.title", value: "If you reach out to us for support by submitting a bug report or through email and agree to be contacted to troubleshoot the issue, we’ll contact you using the information you provide.\n\nIf you participate in a voluntary product survey or questionnaire and agree to provide further feedback, we may contact you using the information you provide.\n\nWe will permanently delete all personal information you provided to us (email, contact information), within 30 days after closing a support case or, in the case of follow up feedback, within 60 days after ending this beta service.", comment: "Privacy Policy list for Network Protection")
static let networkProtectionPrivacyPolicySection5List = NSLocalizedString("network-protection.privacy-policy.section.5.list", value: "If you reach out to us for support by submitting a bug report or through email and agree to be contacted to troubleshoot the issue, we’ll contact you using the information you provide.\n\nIf you participate in a voluntary product survey or questionnaire and agree to provide further feedback, we may contact you using the information you provide.\n\nWe will permanently delete all personal information you provided to us (email, contact information), within 30 days after closing a support case or, in the case of follow up feedback, within 60 days after ending this beta service.", comment: "Privacy Policy list for Network Protection")

static let networkProtectionTermsOfServiceTitle = NSLocalizedString("network-protection.terms-of-service.title", value: "Terms of Service", comment: "Terms of Service title for Network Protection")

Expand All @@ -149,8 +149,8 @@ extension UserText {
static let networkProtectionTermsOfServiceSection7Title = NSLocalizedString("network-protection.terms-of-service.section.7.title", value: "We are continually updating the service.", comment: "Terms of Service title for Network Protection")
static let networkProtectionTermsOfServiceSection7List = NSLocalizedString("network-protection.terms-of-service.section.7.list", value: "The service is in beta, and we are regularly changing it.\n\nService coverage, speed, server locations, and quality may vary without warning.", comment: "Terms of Service list for Network Protection")

static let networkProtectionTermsOfServiceSection8Title = NSLocalizedString("network-protection.terms-of-service.section.7.title", value: "We need your feedback.", comment: "Terms of Service title for Network Protection")
static let networkProtectionTermsOfServiceSection8List = NSLocalizedString("network-protection.terms-of-service.section.7.list", value: "You may be asked during the beta period to provide feedback about your experience. Doing so is optional and your feedback may be used to improve the service.\n\nIf you have enabled notifications for the DuckDuckGo app, we may use notifications to ask about your experience. You can disable notifications if you do not want to receive them.", comment: "Terms of Service list for Network Protection")
static let networkProtectionTermsOfServiceSection8Title = NSLocalizedString("network-protection.terms-of-service.section.8.title", value: "We need your feedback.", comment: "Terms of Service title for Network Protection")
static let networkProtectionTermsOfServiceSection8List = NSLocalizedString("network-protection.terms-of-service.section.8.list", value: "You may be asked during the beta period to provide feedback about your experience. Doing so is optional and your feedback may be used to improve the service.\n\nIf you have enabled notifications for the DuckDuckGo app, we may use notifications to ask about your experience. You can disable notifications if you do not want to receive them.", comment: "Terms of Service list for Network Protection")

}

Expand Down
1 change: 0 additions & 1 deletion LocalPackages/NetworkProtectionMac/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import PackageDescription
let package = Package(
name: "NetworkProtectionMac",
platforms: [
.iOS("14.0"),
.macOS("11.4")
],
products: [
Expand Down
1 change: 0 additions & 1 deletion LocalPackages/PixelKit/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import PackageDescription
let package = Package(
name: "PixelKit",
platforms: [
.iOS("14.0"),
.macOS("11.4")
],
products: [
Expand Down
1 change: 0 additions & 1 deletion LocalPackages/SystemExtensionManager/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import PackageDescription
let package = Package(
name: "SystemExtensionManager",
platforms: [
.iOS("14.0"),
.macOS("11.4")
],
products: [
Expand Down

0 comments on commit 20d7f2d

Please sign in to comment.