fix warnings

duckduckgo · Sep 2, 2024 · 304d6dc · 304d6dc
1 parent ef6ccc9
commit 304d6dc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/DuckDuckGo/Bookmarks/Services/BookmarksContextMenu.swift b/DuckDuckGo/Bookmarks/Services/BookmarksContextMenu.swift
@@ -143,7 +143,7 @@ extension BookmarksContextMenu {
 
     static func menuItems(for folder: BookmarkFolder, target: AnyObject?, forSearch: Bool, includeManageBookmarksItem: Bool) -> [NSMenuItem] {
         // disable "Open All" if no Bookmarks in folder
-        var hasBookmarks = folder.children.contains(where: { $0 is Bookmark })
+        let hasBookmarks = folder.children.contains(where: { $0 is Bookmark })
         var items = [
             openInNewTabsMenuItem(folder: folder, target: target, enabled: hasBookmarks),
             openAllInNewWindowMenuItem(folder: folder, target: target, enabled: hasBookmarks),

diff --git a/DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift b/DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift
@@ -362,7 +362,7 @@ extension DuckPlayerTabExtension: NavigationResponder {
             return
         }
         if navigation.url.isDuckPlayer {
-            var setting = preferences.duckPlayerMode == .enabled ? "always" : "default"
+            let setting = preferences.duckPlayerMode == .enabled ? "always" : "default"
             let newTabSettings = preferences.duckPlayerOpenInNewTab ? "true" : "false"
             let autoplay = preferences.duckPlayerAutoplay ? "true" : "false"
 

diff --git a/DuckDuckGo/Tab/View/BrowserTabViewController.swift b/DuckDuckGo/Tab/View/BrowserTabViewController.swift
@@ -439,7 +439,7 @@ final class BrowserTabViewController: NSViewController {
     private func subscribeToDuckPlayerOnboardingPrompt(of tabViewModel: TabViewModel?) {
         tabViewModel?.tab.duckPlayerOnboardingPublisher.sink { [weak self, weak tab = tabViewModel?.tab] onboardingState in
 
-            guard let self, let tab, let onboardingState = onboardingState, onboardingState.onboardingDecider.canDisplayOnboarding else  {
+            guard let self, tab != nil, let onboardingState = onboardingState, onboardingState.onboardingDecider.canDisplayOnboarding else  {
                 self?.duckPlayerOnboardingModalManager.close(animated: false, completion: nil)
                 return
             }