Skip to content

Commit

Permalink
Changes a pixel name
Browse files Browse the repository at this point in the history
  • Loading branch information
diegoreymendez committed Mar 21, 2024
1 parent 99b12dd commit 4f702e4
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo/Menus/MainMenuActions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ extension MainViewController {
UserDefaults.netP.networkProtectionEntitlementsExpired = false

// Clear pixel data
DailyPixel.clearLastFireDate(pixel: .privacyProEnabled)
DailyPixel.clearLastFireDate(pixel: .privacyProFeatureEnabled)
Pixel.shared?.clearRepetitions(for: .privacyProBetaUserThankYouDBP)
Pixel.shared?.clearRepetitions(for: .privacyProBetaUserThankYouVPN)
}
Expand Down
6 changes: 3 additions & 3 deletions DuckDuckGo/Statistics/PixelEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ extension Pixel {
case dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn

// Subscription
case privacyProEnabled
case privacyProFeatureEnabled
case privacyProBetaUserThankYouVPN
case privacyProBetaUserThankYouDBP
case privacyProSubscriptionActive
Expand Down Expand Up @@ -654,8 +654,8 @@ extension Pixel.Event {
case .defaultRequestedFromOnboarding: return "m_mac_default_requested_from_onboarding"

// MARK: - Subscription
case .privacyProEnabled: return
"m_mac_\(appDistribution)_privacy-pro_enabled"
case .privacyProFeatureEnabled: return
"m_mac_\(appDistribution)_privacy-pro_feature_enabled"
case .privacyProBetaUserThankYouVPN: return "m_mac_\(appDistribution)_privacy-pro_promotion-dialog_shown_vpn"
case .privacyProBetaUserThankYouDBP: return "m_mac_\(appDistribution)_privacy-pro_promotion-dialog_shown_dbp"
case .privacyProSubscriptionActive: return "m_mac_\(appDistribution)_privacy-pro_app_subscription_active"
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/Statistics/PixelParameters.swift
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ extension Pixel.Event {
.defaultRequestedFromHomepageSetupView,
.defaultRequestedFromSettings,
.defaultRequestedFromOnboarding,
.privacyProEnabled,
.privacyProFeatureEnabled,
.privacyProBetaUserThankYouVPN,
.privacyProBetaUserThankYouDBP,
.privacyProSubscriptionActive,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ final class WaitlistThankYouPromptPresenter {
// Wiring this here since it's mostly useful for rolling out PrivacyPro, and should
// go away once PPro is fully rolled out.
if NSApp.delegateTyped.subscriptionFeatureAvailability.isFeatureAvailable {
DailyPixel.fire(pixel: .privacyProEnabled, frequency: .dailyOnly)
DailyPixel.fire(pixel: .privacyProFeatureEnabled, frequency: .dailyOnly)
}

guard canShowPromptCheck() else {
Expand Down

0 comments on commit 4f702e4

Please sign in to comment.