-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Alessandro/bookmarks ship review design (#2386)
Task/Issue URL: https://app.asana.com/0/0/1206818692920856/f **Description**: Fixed Ship Review Design feedback from Bryan. [BB2/](https://app.asana.com/0/0/1206793110089656/1206816441543512/f) [BB4/](https://app.asana.com/0/0/1206793110089656/1206816441543522/f) [BB5/](https://app.asana.com/0/0/1206793110089656/1206816442741770/f)
- Loading branch information
1 parent
872b40d
commit 72f84ec
Showing
10 changed files
with
116 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
UnitTests/Bookmarks/Factory/BookmarksBarMenuFactoryTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // | ||
| // BookmarksBarMenuFactoryTests.swift | ||
| // | ||
| // Copyright © 2024 DuckDuckGo. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import XCTest | ||
| @testable import DuckDuckGo_Privacy_Browser | ||
|
|
||
| final class BookmarksBarMenuFactoryTests: XCTestCase { | ||
|
|
||
| func testReturnAddFolderAndManageBookmarksWhenAddToMenuWithManageBookmarksSectionIsCalled() { | ||
| // GIVEN | ||
| let menu = NSMenu(title: "") | ||
| let targetMock = BookmarksBarTargetMock() | ||
| XCTAssertTrue(menu.items.isEmpty) | ||
|
|
||
| // WHEN | ||
| BookmarksBarMenuFactory.addToMenuWithManageBookmarksSection(menu, target: targetMock, addFolderSelector: #selector(targetMock.addFolder(_:)), manageBookmarksSelector: #selector(targetMock.manageBookmarks)) | ||
|
|
||
| // THEN | ||
| XCTAssertEqual(menu.items.count, 4) | ||
| XCTAssertEqual(menu.items[1].title, "") | ||
| XCTAssertNil(menu.items[1].action) | ||
| XCTAssertEqual(menu.items[2].title, UserText.addFolder) | ||
| XCTAssertEqual(menu.items[2].action, #selector(targetMock.addFolder(_:))) | ||
| XCTAssertEqual(menu.items[3].title, UserText.bookmarksManageBookmarks) | ||
| XCTAssertEqual(menu.items[3].action, #selector(targetMock.manageBookmarks)) | ||
| } | ||
|
|
||
| func testShouldNotReturnAddFolderAndManageBookmarksWhenAddToMenuIsCalled() { | ||
| // GIVEN | ||
| let menu = NSMenu(title: "") | ||
| XCTAssertTrue(menu.items.isEmpty) | ||
|
|
||
| // WHEN | ||
| BookmarksBarMenuFactory.addToMenu(menu) | ||
|
|
||
| // THEN | ||
| XCTAssertEqual(menu.items.count, 1) | ||
| } | ||
| } | ||
|
|
||
| private class BookmarksBarTargetMock: NSObject { | ||
| @objc func addFolder(_ sender: NSMenuItem) {} | ||
| @objc func manageBookmarks() {} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters