Skip to content

Commit

Permalink
fix settings UI
Browse files Browse the repository at this point in the history
  • Loading branch information
SabrinaTardio committed Feb 24, 2024
1 parent 863266a commit 79688d9
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,7 @@ final class BookmarkManagementDetailViewController: NSViewController, NSMenuItem
emptyState.centerXAnchor.constraint(equalTo: separator.centerXAnchor).isActive = true

newBookmarkButton.heightAnchor.constraint(equalToConstant: 24).isActive = true
newBookmarkButton.widthAnchor.constraint(equalToConstant: 130).isActive = true

newFolderButton.widthAnchor.constraint(equalToConstant: 110).isActive = true
newFolderButton.heightAnchor.constraint(equalToConstant: 24).isActive = true

emptyStateMessage.centerXAnchor.constraint(equalTo: emptyState.centerXAnchor).isActive = true
Expand Down
7 changes: 6 additions & 1 deletion DuckDuckGo/Preferences/View/PreferencesGeneralView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,13 @@ extension Preferences {
} else {
Image("Warning").foregroundColor(Color("LinkBlueColor"))
Text(UserText.isNotDefaultBrowser)
Button(UserText.makeDefaultBrowser) {
Button(action: {
defaultBrowserModel.becomeDefault()
}) {
Text(UserText.makeDefaultBrowser)
.fixedSize(horizontal: false, vertical: true)
.multilineTextAlignment(.center)
.lineLimit(2)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public struct TextMenuTitle: View {
public var body: some View {
Text(text)
.font(Const.Fonts.preferencePaneTitle)
.padding(.horizontal)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ public struct FaviconsFetcherOnboardingView: View {

Text(UserText.fetchFaviconsOnboardingTitle)
.font(.system(size: 17, weight: .bold))
.frame(width: 320, alignment: .center)
.multilineTextAlignment(.center)
.fixedSize()

Text(UserText.fetchFaviconsOnboardingMessage)
.frame(width: 320, alignment: .center)
Expand All @@ -57,7 +60,6 @@ public struct FaviconsFetcherOnboardingView: View {
.buttonStyle(DefaultActionButtonStyle(enabled: true))

}
.padding(.vertical, 20)
.frame(width: 360, height: 290)
.frame(width: 360)
}
}

0 comments on commit 79688d9

Please sign in to comment.