Skip to content

Commit

Permalink
Fix release-type checks
Browse files Browse the repository at this point in the history
  • Loading branch information
ayoy committed Mar 2, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent d4c3f3f commit 9f0e939
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/publish_dmg_release.yml
Original file line number Diff line number Diff line change
@@ -45,7 +45,8 @@ jobs:

name: Tag public release

if: github.event.inputs.release-type != 'internal'
# Run if release-type is provided (not empty) an is not internal
if: contains(github.event.inputs.release-type, '') == false && github.event.inputs.release-type != 'internal'

uses: ./.github/workflows/tag_release.yml
with:
@@ -199,7 +200,6 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ secrets.TEST_AWS_ACCESS_KEY_ID_RELEASE_S3 }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.TEST_AWS_SECRET_ACCESS_KEY_RELEASE_S3 }}
AWS_DEFAULT_REGION: ${{ vars.TEST_AWS_DEFAULT_REGION }}
RELEASE_TYPE: ${{ github.event.inputs.release-type }}
VERSION: ${{ steps.verify-tag.outputs.release-version }}
run: |
# Back up existing appcast2.xml
@@ -222,7 +222,7 @@ jobs:
- name: Update Asana for the release
id: update-asana
if: ${{ github.event.inputs.release-type != 'internal' }}
if: ${{ env.RELEASE_TYPE != 'internal' }}
continue-on-error: true
env:
ASANA_ACCESS_TOKEN: ${{ secrets.ASANA_ACCESS_TOKEN }}
@@ -292,7 +292,7 @@ jobs:

- name: Create Asana task to announce the release
id: create-announcement-task
if: ${{ github.event.inputs.release-type != 'internal' }}
if: ${{ env.RELEASE_TYPE != 'internal' }}
uses: ./.github/actions/asana-create-action-item
env:
html-notes: ${{ steps.update-asana.outputs.announcement-task-contents }}
@@ -356,7 +356,8 @@ jobs:

needs: [publish-to-sparkle]

if: ${{ github.event.inputs.release-type != 'internal' }}
# Run if release-type is provided (not empty) an is not internal
if: contains(github.event.inputs.release-type, '') == false && github.event.inputs.release-type != 'internal'

uses: ./.github/workflows/create_variants.yml
secrets:

0 comments on commit 9f0e939

Please sign in to comment.