Skip to content

Commit

Permalink
Removes Home-button temporary pixels (#2027)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1204099484721401/1205814772815391/f


Remove Pixels
- "m_mac_home_button_hidden"
- "m_mac_home_button_left"
- "m_mac_home_button_right"
  • Loading branch information
afterxleep authored Jan 9, 2024
1 parent cf84fbc commit c23d403
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 25 deletions.
8 changes: 0 additions & 8 deletions DuckDuckGo/Preferences/Model/AppearancePreferences.swift
Original file line number Diff line number Diff line change
Expand Up @@ -244,14 +244,6 @@ final class AppearancePreferences: ObservableObject {
@Published var homeButtonPosition: HomeButtonPosition {
didSet {
persistor.homeButtonPosition = homeButtonPosition
switch homeButtonPosition {
case .hidden:
Pixel.fire(.homeButtonHidden)
case .left:
Pixel.fire(.homeButtonLeft)
case .right:
Pixel.fire(.homeButtonRight)
}
}
}

Expand Down
13 changes: 0 additions & 13 deletions DuckDuckGo/Statistics/PixelEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,6 @@ extension Pixel {
// DataBrokerProtection Other
case dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn

// 28-day Home Button
case homeButtonHidden
case homeButtonLeft
case homeButtonRight

case dailyPixel(Event, isFirst: Bool)

enum Debug {
Expand Down Expand Up @@ -558,14 +553,6 @@ extension Pixel.Event {
case .dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn:
return "m_mac_dbp_error_when_fetching_subscription_auth_token_after_sign_in"

// 28-day Home Button
case .homeButtonHidden:
return "m_mac_home_button_hidden"
case .homeButtonLeft:
return "m_mac_home_button_left"
case .homeButtonRight:
return "m_mac_home_button_right"

case .dailyPixel(let pixel, isFirst: let isFirst):
return pixel.name + (isFirst ? "_d" : "_c")
}
Expand Down
5 changes: 1 addition & 4 deletions DuckDuckGo/Statistics/PixelParameters.swift
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,7 @@ extension Pixel.Event {
.dataBrokerProtectionWaitlistCardUITapped,
.dataBrokerProtectionWaitlistTermsAndConditionsDisplayed,
.dataBrokerProtectionWaitlistTermsAndConditionsAccepted,
.dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn,
.homeButtonLeft,
.homeButtonRight,
.homeButtonHidden:
.dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn:
return nil
}
}
Expand Down

0 comments on commit c23d403

Please sign in to comment.