Move VPN ownership to menu agent #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the title
samsymons
reviewed
Oct 4, 2023
samsymons
reviewed
Oct 4, 2023
samsymons
reviewed
Oct 18, 2023
DuckDuckGo/Common/Localizables/UserText+NetworkProtection.swift
Outdated
Show resolved
Hide resolved
Accepting review suggestions. Co-authored-by: Sam Symons <[email protected]>
samsymons
reviewed
Oct 20, 2023
...uckGo/NetworkProtection/AppTargets/BothAppTargets/NetworkProtectionSimulateFailureMenu.swift
Outdated
Show resolved
Hide resolved
samsymons
reviewed
Oct 20, 2023
…VPN App (#1777) Task/Issue URL: https://app.asana.com/0/1203301625297703/1205766254114701/f **Description**: Update provisioning profiles in GHA workflows to work with updated NetP build configuration.
|
Tested the DMG workflows for release and review builds, those worked well 👍 Will do some final checks of this, then I think we can approve it. |
samsymons
reviewed
Oct 21, 2023
Comment on lines
-37
to
-45
| NETP_START_VPN_PROVISION_PROFILE_BASE64: | ||
| required: true | ||
| type: string | ||
| NETP_STOP_VPN_PROVISION_PROFILE_BASE64: | ||
| required: true | ||
| type: string | ||
| NETP_ENABLE_ON_DEMAND_PROVISION_PROFILE_BASE64: | ||
| required: true | ||
| type: string |
samsymons
reviewed
Oct 21, 2023
| "revision" : "57d8ed94cf503fdbd348420e821df00142660333", | ||
| "version" : "81.4.1" | ||
| "revision" : "4089fc0c70830e7cd6b3a574ae3654b365247ac3" |
There was a problem hiding this comment.
Adding a reminder here that this will need to be fixed up before merging
samsymons
approved these changes
Oct 21, 2023
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Oct 22, 2023
Task/Issue URL: https://app.asana.com/0/0/1205738275545702/f iOS PR: duckduckgo/iOS#2101 macOS PR: duckduckgo/macos-browser#1690 What kind of version bump will this require?: Major ## Description Offers improved IPC support in BSK.
diegoreymendez
deleted the
diego/feature/change-netp-vpn-ownership-prototype
branch
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Oct 22, 2023
Task/Issue URL: https://app.asana.com/0/0/1205738275545703/f BSK PR: duckduckgo/BrowserServicesKit#536 macOS PR: duckduckgo/macos-browser#1690 ## Description Integrates the latest changes from BSK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1205529334042574/f
BSK PR: duckduckgo/BrowserServicesKit#536
iOS PR: duckduckgo/iOS#2101
Description
Moves the VPN ownership to the menu agent
Steps to test this PR
Apologies in advance for such a large PR, but this type of fundamental change is hard to split up further than this. I'll list the things that should be tested:
Some aids:
launchctl list | grep duck- to see our launchctl serviceslaunchctl list remove com.duckduckgo.macos.vpn.debugto remove the VPN (debug) agentInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation