This repository has been archived by the owner on Feb 24, 2025. It is now read-only.
Alessandro/bookmarks shortcut panel #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 The Asana task linked in the PR description is not added to macOS App Board project.
|
github-actions
bot
added
the
bot: not in app board
Base automatically changed from
alessandro/address-bookmarks-feedback-bookmark-logic
to
alessandro/address-bookmarks-feedback
February 26, 2024 10:11
…URL to not do anything. Fix by updating existing bookmark
alessandroboron
force-pushed
the
alessandro/bookmarks-shortcut-panel
branch
from
ab4226e to
8b60abf
Compare
SabrinaTardio
approved these changes
Feb 26, 2024
No yet, but I made myself a task to investigate the issue https://app.asana.com/0/0/1206687983236914/f |
alessandroboron
merged commit e9e5e7e
into
alessandro/address-bookmarks-feedback
16 of 17 checks passed
alessandroboron
added a commit
that referenced
this pull request
Feb 27, 2024
Task/Issue URL: https://app.asana.com/0/0/1206670741563549/f **Description**: 1. “Three dots hover” menu button for Bookmarks and Folders in the bookmarks shortcut panel. 2. Add “Star" icon for favorite bookmarks. 3. Enhance Contextual Menu with "Edit…” for both folders and bookmarks. 4. Present Add/Edit Bookmarks/Folder dialogs.
alessandroboron
added a commit
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1206670741563549/f **Description**: 1. “Three dots hover” menu button for Bookmarks and Folders in the bookmarks shortcut panel. 2. Add “Star" icon for favorite bookmarks. 3. Enhance Contextual Menu with "Edit…” for both folders and bookmarks. 4. Present Add/Edit Bookmarks/Folder dialogs.
alessandroboron
added a commit
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1206670741563549/f **Description**: 1. “Three dots hover” menu button for Bookmarks and Folders in the bookmarks shortcut panel. 2. Add “Star" icon for favorite bookmarks. 3. Enhance Contextual Menu with "Edit…” for both folders and bookmarks. 4. Present Add/Edit Bookmarks/Folder dialogs.
alessandroboron
added a commit
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1206670741563549/f **Description**: 1. “Three dots hover” menu button for Bookmarks and Folders in the bookmarks shortcut panel. 2. Add “Star" icon for favorite bookmarks. 3. Enhance Contextual Menu with "Edit…” for both folders and bookmarks. 4. Present Add/Edit Bookmarks/Folder dialogs.
alessandroboron
added a commit
that referenced
this pull request
Mar 14, 2024
Task/Issue URL: https://app.asana.com/0/0/1206670741563549/f **Description**: 1. “Three dots hover” menu button for Bookmarks and Folders in the bookmarks shortcut panel. 2. Add “Star" icon for favorite bookmarks. 3. Enhance Contextual Menu with "Edit…” for both folders and bookmarks. 4. Present Add/Edit Bookmarks/Folder dialogs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206670741563549/f
CC: @samsymons
Description:
Figma Mockup
NOTE
This PR doesn’t include the new structure for the contextual menu as per design. It just includes the “Edit…” menu item
Steps to test this PR:
Scenario 1: Adding a new Bookmark to Root Folder from top button 🟢
Expected Result: The new bookmark should appear in the list within the root bookmarks folder.
Scenario 2: Adding a new Bookmark to specific folder from top button 🟢
Expected Result: The new bookmark should appear in the list within the specified folder.
**Scenario 3: Adding a new Bookmark with same address and location of an existing one but different name ** ❌
Expected Result: The bookmark shouldn’t be duplicated and the existing one should update name.
Actual Result: The bookmark list does not update. only upon close and re-open.
Update: This seems similar to an issue in production where when adding a new bookmark with same URL and different name we cannot see the changes upon reopening the panel. I suspect that there’s an issue in
BookmarkOutlineViewDataSourceas theBookmarkListViewControllersink on the List and receives the right items. This requires a bit of investigation.Scenario 4: Adding a new Bookmark with same address of an existing one but different name & location 🟢
Expected Result: The bookmark should be updated and move to a different location.
Scenario 5: Adding a new Folder to Root Folder from top button 🟢
Expected Result: The folder should be added to the root bookmarks folder.
Scenario 6: Adding a new Folder to specific folder from top button 🟢
Expected Result: The folder should be added as child within the specified folder.
Scenario 7: Adding a new Folder with same name of an exisiting one 🟢
Expected Result: The folder should be duplicated (as per existing behaviour in production).
Scenario 8: Editing a Folder from Context Menu 🟢
Expected Result: The folder should update name/location and its content should still be available.
Scenario 9: Editing a Bookmark from Context Menu - Change Name 🟢
Expected Result: The bookmark should update name.
Scenario 10: Editing a Bookmark from Context Menu - Change Name and URL ❌
Expected Result: The bookmark should update name.
Actual Result: The bookmark updates upon closing & reopening the panel.
Update:This seems similar to an issue in production where when adding a new bookmark with same URL and different name we cannot see the changes upon reopening the panel. I suspect that there’s an issue in
BookmarkOutlineViewDataSourceas theBookmarkListViewControllersink on the List and receives the right items. This requires a bit of investigation.Scenario 11: Editing a Bookmark from Context Menu -Change Name, URL and Location 🟢
Expected Result: The bookmark should update name and URL and move to the specified location.
**Scenario 12: Adding to Favorites” 🟢
Expected Result: The bookmark should show a star icon.
**Scenario 13: Removing from Favorites” 🟢
Expected Result: The bookmark should not show a star icon.
**Scenario 14: Adding a Bookmark from Tab that has a loaded web page” 🟢
Expected Result: The bookmark name and title should be prefilled with the web page information.
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation