Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix settings UI #2258

Merged
merged 5 commits into from
Feb 28, 2024
Merged

fix settings UI #2258

merged 5 commits into from
Feb 28, 2024

Conversation

SabrinaTardio
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/0/1206634378116396/f

Description: Fix ui for settings, bookmarks and fetch favicon onboarding

Steps to test this PR:

  1. In the edit scheme menu in Xcode in the App Language section select Double-Lenght Pseudolanguage. Look at the screens in https://app.asana.com/0/1199230911884351/1206634378116396/f and https://app.asana.com/0/0/1206634378116398/f and check issues are fixed (Bookmark title is ok unfixed since will work with any of the languages)
  2. Run the app normally and check the same screens look as expected.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@SabrinaTardio SabrinaTardio requested a review from ayoy February 24, 2024 14:40
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@SabrinaTardio SabrinaTardio merged commit b3609a2 into main Feb 28, 2024
17 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/fix_settings_ui branch February 28, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants