Disable transparent proxy in app store builds #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
diegoreymendez
removed
the
bot: not in app board
github-actions
bot
added
the
bot: not in app board
github-actions
bot
removed
the
bot: not in app board
diegoreymendez
commented
Feb 26, 2024
| @@ -8502,6 +8500,7 @@ | |||
| 4B2D06672A13318400DE1F49 /* Resources */, | |||
| 4B2D067D2A13341200DE1F49 /* ShellScript */, | |||
| 4BA7C4E02B3F6F7500AFE511 /* Embed Network Extensions */, | |||
| 7B557F2A2B8CA2A400099746 /* Embed Debug-only Network Extensions */, | |||
There was a problem hiding this comment.
New script phase for conditionally including the transparent proxy target.
diegoreymendez
commented
Feb 26, 2024
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "# Support for embedding debug-only extensions (https://stackoverflow.com/a/76948057/712306)\nfunction embedExtensions() {\n for extension in $1\n do\n rsync -r --copy-links \"${CONFIGURATION_BUILD_DIR}/${extension}.appex\" \"${CONFIGURATION_BUILD_DIR}/${PLUGINS_FOLDER_PATH}\"\n done\n}\n\ndebug_extensions=(\"VPNProxyExtension\")\n\nif [ \"${CONFIGURATION}\" != \"Release\" ]\nthen\n embedExtensions $debug_extensions\nfi\n"; | ||
| }; |
There was a problem hiding this comment.
Includes VPNProxyExtension.appex conditionally.
diegoreymendez
commented
Feb 26, 2024
| @@ -3274,7 +3273,6 @@ | |||
| dstPath = ""; | |||
| dstSubfolderSpec = 13; | |||
| files = ( | |||
| 7BDA36F92B7E084A00AD5388 /* VPNProxyExtension.appex in Embed Network Extensions */, | |||
There was a problem hiding this comment.
We're no longer embedding this unconditionally. We don't want this for release builds yet.
…/macos-browser into diego/disable-tp-in-app-store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206690644131121/f
Description
Disables the transparent proxy in App Store builds.
Testing
Contents/Library/DuckDuckGo VPN.app/Contents/PlugInsContents/Library/DuckDuckGo VPN.app/Contents/PlugInsInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation