Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressBar opt+return to download, cmd+opt to open new window #2262

Merged
merged 24 commits into from
Mar 1, 2024

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/0/1202118286733117/f

Description:

  • Downloads a URL on Option+Return in the Address Bar
  • Cmd+Opt to open in new window (+shift - selected)

Steps to test this PR:

  1. Validate Opt+return in the address bar downloads from URL
  2. Validate about: and download url spoofing cases from https://privacy-test-pages.site/security/address-bar-spoofing/index.html
  3. Validate Cmd+Opt[+shift] opens url in a new window (below current window, if with shift - above current window)

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from ayoy February 26, 2024 15:07
Base automatically changed from alex/fix-address-bar-cleared-on-nav to main February 27, 2024 11:15
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@mallexxx mallexxx merged commit 659f95f into main Mar 1, 2024
17 checks passed
@mallexxx mallexxx deleted the alex/addressbar-opt-download branch March 1, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants