Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add estimated download time #2263

Merged
merged 15 commits into from
Mar 1, 2024
Merged

Add estimated download time #2263

merged 15 commits into from
Mar 1, 2024

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199178362774117/1201661861647413/f

Description:

  • Adds estimated download time and speed to downloads

Steps to test this PR:

  1. Start some big download; validate remaining time displayed in downloads, full info with speed displayed in the tooltip

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👏

@mallexxx mallexxx assigned mallexxx and unassigned SabrinaTardio Feb 29, 2024
@mallexxx mallexxx merged commit a1ddace into main Mar 1, 2024
17 checks passed
@mallexxx mallexxx deleted the alex/download-estimated-time branch March 1, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants