Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open last valid downloads folder if no files downloaded to default #2264

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1203968847972801/f

Description:

  • Opens a download folder with a last downloaded file if no downloaded files in default downloads folder or if "always request location" is set

Steps to test this PR:

  1. Select "Always request location", downloads some files somewhere, click "Open downloads folder" in Downloads - validate last download location is open
  2. Clear list, validate Downloads folder is open
  3. Unselect "always request location", Set some downloads location, validate it‘s open
  4. Save some image As - save somewhere outside of Downloads; click Open Downloads - validate Downloads folder is open

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@mallexxx mallexxx merged commit 0547b52 into main Mar 1, 2024
17 checks passed
@mallexxx mallexxx deleted the alex/open-actual-downloads-folder branch March 1, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants