Automate Asana paperwork for public releases #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add the task as part of publish_dmg_release
github-actions
bot
added
bot: not in app board
ayoy
commented
Feb 29, 2024
ayoy
commented
Feb 29, 2024
Comment on lines
+303
to
+331
| handle_public_release() { | ||
| local incidents_parent_task_id="${INCIDENTS_PARENT_TASK_ID:-${default_incidents_parent_task_id}}" | ||
| local current_objectives_project_id="${CURRENT_OBJECTIVES_PROJECT_ID:-${default_current_objectives_project_id}}" | ||
|
|
||
| # 1. Get the existing Asana tag for the release. | ||
| local tag_id | ||
| tag_id=$(find_asana_release_tag "$marketing_version") | ||
|
|
||
| # 2. Fetch task IDs for the release tag. | ||
| local task_ids | ||
| read -ra task_ids <<< "$(fetch_tagged_tasks_ids "$tag_id")" | ||
|
|
||
| # 3. Move all tasks to Done section. | ||
| move_tasks_to_section "$target_section_id" "${task_ids[@]}" | ||
|
|
||
| # 4. Complete tasks that don't require a post-mortem. | ||
| complete_tasks "${task_ids[@]}" | ||
|
|
||
| # 5. Fetch current release notes from Asana release task. | ||
| local release_notes=() | ||
| while read -r line; do | ||
| release_notes+=("$line") | ||
| done <<< "$(fetch_current_release_notes "${release_task_id}")" | ||
|
|
||
| # 6. Construct release announcement task description | ||
| local html_notes | ||
| html_notes="$(construct_release_announcement_task_description)" | ||
| cat > "${announcement_task_contents_file}" <<< "${html_notes}" | ||
| } |
There was a problem hiding this comment.
This is the main thing being added in this PR
samsymons
reviewed
Mar 1, 2024
| echo "${task_ids[@]}" | ||
| } | ||
|
|
||
| fetch_incident_task_ids() { |
samsymons
approved these changes
Mar 1, 2024
diegoreymendez
pushed a commit
that referenced
this pull request
Mar 1, 2024
Task/Issue URL: https://app.asana.com/0/0/1206628689034177/f Description: This change updates publish_dmg_release workflow so that it moves release-related tasks to Done column in macOS App Board, closes them (all but the release task, incident tasks and Current Objectives projects), run Create DMG Variants pipeline and instructs the release DRI to announce the release to the company.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206628689034177/f
CC: @loremattei
Description:
This change updates publish_dmg_release workflow so that it moves release-related tasks to Done column
in macOS App Board, closes them (all but the release task, incident tasks and Current Objectives projects),
run Create DMG Variants pipeline and instructs the release DRI to announce the release to the company.
Steps to test this PR:
Verify the following items:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation