-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds pixels to track main VPN funnels #2304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the title
Adds pixels to track attempts to start the VPN controller
macOS: Adds pixels to track main VPN funnels
Mar 5, 2024
diegoreymendez
changed the title
macOS: Adds pixels to track main VPN funnels
Adds pixels to track main VPN funnels
Mar 5, 2024
diegoreymendez
force-pushed
the
diego/vpn-controller-pixels
branch
from
March 5, 2024 15:09
4ea52ac
to
737dd22
Compare
samsymons
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we'll need to create a BSK hotfix release with those changes before merging this to the release branch.
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1206737255908394/f macOS PR: duckduckgo/macos-browser#2304 iOS PR: duckduckgo/iOS#2543 ## Description Add pixels to better track all main VPN funnels. For BSK this means: - VPN Tunnel Start - VPN Tunnel Update (change location, etc)
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1206737255908394/f macOS PR: duckduckgo/macos-browser#2304 BSK PR: duckduckgo/BrowserServicesKit#698 ## Description Add pixels to better track all main VPN funnels: - VPN Controller Start - VPN Tunnel Start - VPN Tunnel Update (change location, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206737255908394/f
iOS PR: duckduckgo/iOS#2543
BSK PR: duckduckgo/BrowserServicesKit#698
Description
Add pixels to better track all main VPN funnels:
Testing
Setup
open ~/Library/Group\ Containers/HKE973VLUW.com.duckduckgo.macos.browser.network-protection.system-extension.debug/Library/Preferences/HKE973VLUW.com.duckduckgo.macos.browser.network-protection.system-extension.debug.plist
Test 1: start success
m_mac_netp_controller_start_attempt
m_mac_netp_controller_start_success
m_mac_netp_tunnel_start_attempt
m_mac_netp_tunnel_start_success
Test 2: controller start failure
m_mac_netp_controller_start_attempt
m_mac_netp_controller_start_failure
(this should include error info)Test 3: tunnel start failure
m_mac_netp_controller_start_attempt
m_mac_netp_controller_start_success
m_mac_netp_tunnel_start_attempt
m_mac_netp_tunnel_start_falure
(this should include error info)Test 4: tunnel update success
m_mac_netp_tunnel_update_attempt
m_mac_netp_tunnel_update_success
Test 5: tunnel update failure
m_mac_netp_tunnel_update_attempt
m_mac_netp_tunnel_update_failure
(this should include error info)Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation