Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Peoplewhiz data broker #2310

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Add Peoplewhiz data broker #2310

merged 5 commits into from
Mar 6, 2024

Conversation

brianhall
Copy link
Collaborator

@brianhall brianhall commented Mar 4, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206660599382381/f
Tech Design URL:
CC:

Description:
Adds Beenverified and Peoplewhiz data brokers

Steps to test this PR:
1.


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 4, 2024
@brianhall brianhall removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 5, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 5, 2024
@brianhall brianhall removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 5, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 5, 2024
@Bunn Bunn removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 5, 2024
Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bunn
Copy link
Collaborator

Bunn commented Mar 6, 2024

@brianhall I removed beenverified, other than that LGTM, feel free to merge whenever

@brianhall brianhall changed the title Add Peoplewhiz and Beenverified data brokers Add Peoplewhiz data broker Mar 6, 2024
@brianhall brianhall merged commit a574164 into main Mar 6, 2024
21 checks passed
@brianhall brianhall deleted the bhall/04-03-new-brokers branch March 6, 2024 16:04
samsymons added a commit that referenced this pull request Mar 6, 2024
# By Alexey Martemyanov (10) and others
# Via GitHub
* main: (39 commits)
  Add Peoplewhiz data broker (#2310)
  Integrate confirm entitlements endpoint for macOS App Store purchase (#2325)
  Make dbSaveBloomFilterError pixel daily and continuous (#2299)
  Subscription UI updates (#2303)
  Add email pattern on opt-out pixel (#2307)
  Use compile-time checked generated asset names (#2177)
  fix bundle name in breakByRaisingSigInt (#2319)
  BSK update for iOS autofill support to delete all passwords (#2254)
  Bump BrowserServicesKit (#2309)
  Bump version to 1.78.0 (132)
  Fix crash on popup window display; adjust naming (#2315)
  Bump version to 1.78.0 (131)
  Set marketing version to 1.78.0
  Update embedded files
  Fix parsing commit log (#2311)
  DBP: Set correct duration of submit-success pixel (#2308)
  Publish subsequent internal releases right after building (#2306)
  DBP disable pixel changes (#2293)
  Remove duplicated broker items (#2294)
  fix tab title not updated (#2302)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants