Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetP x Subscription Clean-up #2363

Merged
merged 12 commits into from
Mar 14, 2024
Merged

NetP x Subscription Clean-up #2363

merged 12 commits into from
Mar 14, 2024

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Mar 8, 2024

Task/Issue URL: https://app.asana.com/0/0/1206470585910126/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. This shouldn't break existing flows (either in ALPHA or non-ALPHA build)
  2. Refer to https://app.asana.com/0/0/1206398972819576/f for test cases

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@quanganhdo quanganhdo marked this pull request as ready for review March 11, 2024 04:18
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
quanganhdo added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Mar 14, 2024
@quanganhdo quanganhdo merged commit b4b968d into main Mar 14, 2024
17 checks passed
@quanganhdo quanganhdo deleted the anh/netp-subscription-clean-up branch March 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants