DBP: Add stage granularity to Pixels #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
changed the title
github-actions
bot
added
the
bot: not in app board
q71114
reviewed
Mar 11, 2024
...kages/DataBrokerProtection/Sources/DataBrokerProtection/Operations/DataBrokerOperation.swift
Outdated
Show resolved
Hide resolved
github-actions
bot
added
bot: not in app board
jotaemepereira
removed
the
bot: not in app board
Bunn
reviewed
Mar 14, 2024
...kages/DataBrokerProtection/Sources/DataBrokerProtection/Operations/DataBrokerOperation.swift
Outdated
Show resolved
Hide resolved
jotaemepereira
force-pushed
the
juan/dbp/stage-granularity-pixel
branch
2 times, most recently
from
8124cb1 to
6cdf8e6
Compare
jotaemepereira
force-pushed
the
juan/dbp/stage-granularity-pixel
branch
from
6cdf8e6 to
f99c05c
Compare
samsymons
added a commit
that referenced
this pull request
Mar 16, 2024
* main: (22 commits) Bump BSK (#2435) Bump version to 1.80.0 (145) Fix syntax in Asana actions Bump version to 1.80.0 (144) Set marketing version to 1.80.0 Update embedded files DBP: Debug scan model implementation (#2421) Roll back CPM post-rollout cleanup (#2430) Password Import: Ignore Excluded Sites When Importing from Chrome (#2404) Stub objects for Bookmarks DB (#2418) Properly handle edge cases (#2417) DBP: Treat 404 as failure instead of error (#2426) DBP: Use url instead of name to identify brokers on pixels (#2423) Fix determining if internal release should be automatically bumped Renamed some pixel parameters to be more clear (#2402) Update broker json (#2407) bump bsk to fix retain cycle (#2425) Bump version to 1.79.0 (143) bump bsk to fix retain cycle (#2422) DBP: Add stage granularity to Pixels (#2365) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206767326073685/f
Tech Design URL:
CC:
Description
Adds more granularity to the stages when firing the opt-out stage pixels.
Steps to test this PR:
Run an opt-out operation on PIR
Debug the
DataBrokerProtectionStageDurationCalculatorCheck that stages are being set correctly
Run an opt-out operation on PIR
Make the opt-out fail (you can throw from the
EmailServiceorCaptcha Service)When the
fireOptOutFailureis called, check the stage is correct.Check the failure Pixel has the actionID that failed
Run an opt-out operation on PIR
Run the fill form action
If the action succeeds, check that the
fill-formpixel is being fired.