Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broker json #2407

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Update broker json #2407

merged 3 commits into from
Mar 14, 2024

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Mar 13, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206835317209633/f

Description:
Add unique name for PeopleWhiz child sites

Steps to test this PR:
Do not use the DBP Debug version for this test

  1. Either clean your database or change the app version to force an app update
  2. Run a full scan, check if the people whiz child sites were correctly added to the database

Copy link
Contributor

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 125319e

Copy link
Collaborator

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bunn Bunn merged commit e1f7ab0 into main Mar 14, 2024
17 checks passed
@Bunn Bunn deleted the bunn/dbp/broker-json branch March 14, 2024 20:15
samsymons added a commit that referenced this pull request Mar 16, 2024
* main: (22 commits)
  Bump BSK (#2435)
  Bump version to 1.80.0 (145)
  Fix syntax in Asana actions
  Bump version to 1.80.0 (144)
  Set marketing version to 1.80.0
  Update embedded files
  DBP: Debug scan model implementation (#2421)
  Roll back CPM post-rollout cleanup (#2430)
  Password Import: Ignore Excluded Sites When Importing from Chrome (#2404)
  Stub objects for Bookmarks DB (#2418)
  Properly handle edge cases (#2417)
  DBP: Treat 404 as failure instead of error (#2426)
  DBP: Use url instead of name to identify brokers on pixels (#2423)
  Fix determining if internal release should be automatically bumped
  Renamed some pixel parameters to be more clear (#2402)
  Update broker json (#2407)
  bump bsk to fix retain cycle (#2425)
  Bump version to 1.79.0 (143)
  bump bsk to fix retain cycle (#2422)
  DBP: Add stage granularity to Pixels (#2365)
  ...
samsymons added a commit that referenced this pull request Mar 18, 2024
# By Dax the Duck (5) and others
# Via GitHub (2) and Chris Brind (1)
* main: (30 commits)
  Update wireguard-apple to 1.1.3 (#2428)
  Improves VPN pixel info and adds tests (#2434)
  DBP: Implement event pixels (#2408)
  Bump BSK (#2435)
  Bump version to 1.80.0 (145)
  Fix syntax in Asana actions
  Bump version to 1.80.0 (144)
  Set marketing version to 1.80.0
  Update embedded files
  DBP: Debug scan model implementation (#2421)
  Roll back CPM post-rollout cleanup (#2430)
  Password Import: Ignore Excluded Sites When Importing from Chrome (#2404)
  Stub objects for Bookmarks DB (#2418)
  Properly handle edge cases (#2417)
  DBP: Treat 404 as failure instead of error (#2426)
  DBP: Use url instead of name to identify brokers on pixels (#2423)
  Fix determining if internal release should be automatically bumped
  Renamed some pixel parameters to be more clear (#2402)
  Update broker json (#2407)
  bump bsk to fix retain cycle (#2425)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants