DBP: Implement event pixels #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
force-pushed
the
juan/dbp/implement-kpi-event-pixels
branch
from
2558f4e to
4cf20fe
Compare
jotaemepereira
force-pushed
the
juan/dbp/implement-kpi-event-pixels
branch
4 times, most recently
from
1be3664 to
d5ee333
Compare
Bunn
reviewed
Mar 15, 2024
...taBrokerProtection/Sources/DataBrokerProtection/Pixels/DataBrokerProtectionEventPixels.swift
Show resolved
Hide resolved
Bunn
approved these changes
Mar 15, 2024
jotaemepereira
force-pushed
the
juan/dbp/implement-kpi-event-pixels
branch
from
feb98e4 to
7d0dc46
Compare
samsymons
added a commit
that referenced
this pull request
Mar 18, 2024
# By Juan Manuel Pereira (4) and others # Via GitHub * main: Improves VPN pixel info and adds tests (#2434) DBP: Implement event pixels (#2408) Bump BSK (#2435) Bump version to 1.80.0 (145) Fix syntax in Asana actions Bump version to 1.80.0 (144) Set marketing version to 1.80.0 Update embedded files DBP: Debug scan model implementation (#2421) Roll back CPM post-rollout cleanup (#2430) Password Import: Ignore Excluded Sites When Importing from Chrome (#2404) Stub objects for Bookmarks DB (#2418) Properly handle edge cases (#2417) DBP: Treat 404 as failure instead of error (#2426) DBP: Use url instead of name to identify brokers on pixels (#2423) Fix determining if internal release should be automatically bumped # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Mar 18, 2024
# By Dax the Duck (5) and others # Via GitHub (2) and Chris Brind (1) * main: (30 commits) Update wireguard-apple to 1.1.3 (#2428) Improves VPN pixel info and adds tests (#2434) DBP: Implement event pixels (#2408) Bump BSK (#2435) Bump version to 1.80.0 (145) Fix syntax in Asana actions Bump version to 1.80.0 (144) Set marketing version to 1.80.0 Update embedded files DBP: Debug scan model implementation (#2421) Roll back CPM post-rollout cleanup (#2430) Password Import: Ignore Excluded Sites When Importing from Chrome (#2404) Stub objects for Bookmarks DB (#2418) Properly handle edge cases (#2417) DBP: Treat 404 as failure instead of error (#2426) DBP: Use url instead of name to identify brokers on pixels (#2423) Fix determining if internal release should be automatically bumped Renamed some pixel parameters to be more clear (#2402) Update broker json (#2407) bump bsk to fix retain cycle (#2425) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Mar 19, 2024
* main: Remove hardcoded NetP staging endpoint (#2446) DBP: Make webview non-persistent and delete any old cache data (#2445) Prevents the tunnel from starting without an auth token (#2438) Use History in Suggestions on iOS (#2339) When publishing a DMG, only check out the branch if it exists, otherwise stay on main Bump version to 1.80.0 (146) Update wireguard-apple to 1.1.3 (#2428) Improves VPN pixel info and adds tests (#2434) Update autoconsent to v10.3.0 (#2433) DBP: Implement event pixels (#2408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206656675196362/f
Tech Design URL:
CC:
Description:
Implements the event pixels defined here: https://app.asana.com/0/0/1206366823020815/f
I’m adding add new four Pixels that are contained inside the
DataBrokerProtectionEventPixelsclass.Weekly Report Scanning
Pixel name:
dbp.event.weekly-report.scanningParams
had_new_match: User had at least one new match (yes/no)had_re-appearance: User had at least one re-appearance (previously-removed item reappeared) (yes/no)scan_coverage: % of all brokers scanned that week (0-25%, 25-50%, 50-75% or 75-100%)Weekly Report Removals
Pixel name:
dbp.event.weekly-report.removalsParams
removals: Number of removals completed that weekScanning events
Pixel name:
dbp.event.scanning-events.new-match- Fire a pixel for each new match (record) foundPixel name:
dbp.event.scanning-events.re-appearance- Fire a pixel for each re-appearance foundSteps to test this PR:
Test the weekly pixels
Test the new match found pixel
dbp.event.scanning-events.new-matchis fired when a new match is foundTest the re-appearance pixel
This one is harder to test because we need to mimic a record that was found and removed, and then the record was added again by the broker. To do this, find a new match and mark it as removed (even was not removed), then do a scan and it should be marked as re appearance then check the
dbp.event.scanning-events.new-matchis firedfound