iOS UI improvements #2412
Merged
iOS UI improvements #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# By Dax the Duck (5) and others # Via GitHub (2) and Chris Brind (1) * main: (30 commits) Update wireguard-apple to 1.1.3 (#2428) Improves VPN pixel info and adds tests (#2434) DBP: Implement event pixels (#2408) Bump BSK (#2435) Bump version to 1.80.0 (145) Fix syntax in Asana actions Bump version to 1.80.0 (144) Set marketing version to 1.80.0 Update embedded files DBP: Debug scan model implementation (#2421) Roll back CPM post-rollout cleanup (#2430) Password Import: Ignore Excluded Sites When Importing from Chrome (#2404) Stub objects for Bookmarks DB (#2418) Properly handle edge cases (#2417) DBP: Treat 404 as failure instead of error (#2426) DBP: Use url instead of name to identify brokers on pixels (#2423) Fix determining if internal release should be automatically bumped Renamed some pixel parameters to be more clear (#2402) Update broker json (#2407) bump bsk to fix retain cycle (#2425) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
|
Looks like unit tests are failing for legitimate reasons, I'll get that fixed up on Monday. |
# By Michal Smaga (2) and others # Via GitHub (2) and Dominik Kapusta (1) * main: Connect thank you message to DBP method (#2456) Use SubscriptionFeatureAvailability to determine availability of the subscription (#2436) Add Privacy Pro to App Store build (#2440) Display error messaging for cancelled subscriptions (#2394) Updated Settings Page (#2329) Add VPN & PIR thank you modal (#2437) Web pixels (handlers + pixels) (#2451) Subscription design review further fixes (#2448) Address bookmarks feedback (#2411) Handle subscription-related iOS use cases (#2427) Remove hardcoded NetP staging endpoint (#2446) DBP: Make webview non-persistent and delete any old cache data (#2445) Prevents the tunnel from starting without an auth token (#2438) Use History in Suggestions on iOS (#2339) When publishing a DMG, only check out the branch if it exists, otherwise stay on main Bump version to 1.80.0 (146) Update autoconsent to v10.3.0 (#2433) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
6 tasks
graeme
approved these changes
Mar 20, 2024
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Mar 20, 2024
Required: Task/Issue URL: https://app.asana.com/0/0/1206827305053615/f iOS PR: duckduckgo/iOS#2583 macOS PR: duckduckgo/macos-browser#2412 What kind of version bump will this require?: Major Description: This PR adds a new message type to the VPN which allows callers to get the throughput from WireGuard.
samsymons
added a commit
that referenced
this pull request
Mar 21, 2024
# By Diego Rey Mendez (4) and others # Via GitHub (2) and Dominik Kapusta (1) * main: (28 commits) Entitlements cache fixes (#2465) BSK update for RMF app build version improvement (#2362) Surface the last-used password first in autofill prompt when filling passwords (#2431) Reset subs VPN state from debug menu (#2462) iOS UI improvements (#2412) Updates VPN 128 assets (#2459) Fix sparkle strings for thank you message (#2461) Wire VPN environment to subs menu item (#2460) Makes a method thread safe (#2452) Ensure smooth subs updates (#2424) Update Pointfree snapshot testing library to 1.15.4 (#2449) Connect thank you message to DBP method (#2456) Use SubscriptionFeatureAvailability to determine availability of the subscription (#2436) Add Privacy Pro to App Store build (#2440) Display error messaging for cancelled subscriptions (#2394) Updated Settings Page (#2329) Add VPN & PIR thank you modal (#2437) Web pixels (handlers + pixels) (#2451) Subscription design review further fixes (#2448) Address bookmarks feedback (#2411) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206836179343895/f
Tech Design URL:
CC:
Description:
This PR updates BSK to the iOS UI improvements branch.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation