-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBP: Debug scan model implementation #2421
Merged
jotaemepereira
merged 5 commits into
main
from
juan/dbp/end-to-end-data-broker-matching
Mar 15, 2024
Merged
DBP: Debug scan model implementation #2421
jotaemepereira
merged 5 commits into
main
from
juan/dbp/end-to-end-data-broker-matching
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
force-pushed
the
juan/dbp/end-to-end-data-broker-matching
branch
from
March 14, 2024 18:59
b82753b
to
b9321fb
Compare
Bunn
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
samsymons
added a commit
that referenced
this pull request
Mar 16, 2024
* main: (22 commits) Bump BSK (#2435) Bump version to 1.80.0 (145) Fix syntax in Asana actions Bump version to 1.80.0 (144) Set marketing version to 1.80.0 Update embedded files DBP: Debug scan model implementation (#2421) Roll back CPM post-rollout cleanup (#2430) Password Import: Ignore Excluded Sites When Importing from Chrome (#2404) Stub objects for Bookmarks DB (#2418) Properly handle edge cases (#2417) DBP: Treat 404 as failure instead of error (#2426) DBP: Use url instead of name to identify brokers on pixels (#2423) Fix determining if internal release should be automatically bumped Renamed some pixel parameters to be more clear (#2402) Update broker json (#2407) bump bsk to fix retain cycle (#2425) Bump version to 1.79.0 (143) bump bsk to fix retain cycle (#2422) DBP: Add stage granularity to Pixels (#2365) ...
samsymons
added a commit
that referenced
this pull request
Mar 18, 2024
# By Juan Manuel Pereira (4) and others # Via GitHub * main: Improves VPN pixel info and adds tests (#2434) DBP: Implement event pixels (#2408) Bump BSK (#2435) Bump version to 1.80.0 (145) Fix syntax in Asana actions Bump version to 1.80.0 (144) Set marketing version to 1.80.0 Update embedded files DBP: Debug scan model implementation (#2421) Roll back CPM post-rollout cleanup (#2430) Password Import: Ignore Excluded Sites When Importing from Chrome (#2404) Stub objects for Bookmarks DB (#2418) Properly handle edge cases (#2417) DBP: Treat 404 as failure instead of error (#2426) DBP: Use url instead of name to identify brokers on pixels (#2423) Fix determining if internal release should be automatically bumped # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Mar 18, 2024
# By Dax the Duck (5) and others # Via GitHub (2) and Chris Brind (1) * main: (30 commits) Update wireguard-apple to 1.1.3 (#2428) Improves VPN pixel info and adds tests (#2434) DBP: Implement event pixels (#2408) Bump BSK (#2435) Bump version to 1.80.0 (145) Fix syntax in Asana actions Bump version to 1.80.0 (144) Set marketing version to 1.80.0 Update embedded files DBP: Debug scan model implementation (#2421) Roll back CPM post-rollout cleanup (#2430) Password Import: Ignore Excluded Sites When Importing from Chrome (#2404) Stub objects for Bookmarks DB (#2418) Properly handle edge cases (#2417) DBP: Treat 404 as failure instead of error (#2426) DBP: Use url instead of name to identify brokers on pixels (#2423) Fix determining if internal release should be automatically bumped Renamed some pixel parameters to be more clear (#2402) Update broker json (#2407) bump bsk to fix retain cycle (#2425) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206708876900016/f
Tech Design URL:
CC:
Description
Implements a debug option to run PIR in all brokers. This debug option will create a folder in the user’s Desktop folder called
PIR-Test
that contains an output.csv with data of the results, plus two other folders, HTML and Screenshots, with information about the results for each broker.Steps to test this PR: