Code

UI Tests: Find in Page#2443

Code

Merged

Halle merged 41 commits intomainduckduckgo/macos-browser:mainfrom halle/find-in-page-testsduckduckgo/macos-browser:halle/find-in-page-testsCopy head branch name to clipboardMar 22, 2024

+637-19

Commits

Commits on Mar 14, 2024

• Add accessibiity identifiers for Find in Page controller elements

  Halle

  committed
  fdf89c3

  Copy full SHA for fdf89c3

• Add accessibilityIdentifier to NSMenuItemExtension.swift

  Halle

  committed
  f4270bc

  Copy full SHA for f4270bc

• Set accessibilityIdentifier for address bar text field

  Halle

  committed
  55e0e42

  Copy full SHA for 55e0e42

• Add accessibilityIdentifier for Find in Page menu item

  Halle

  committed
  1141095

  Copy full SHA for 1141095

• Add FindInPageTests.swift to project

  Halle

  committed
  1b74f49

  Copy full SHA for 1b74f49

• Add more accessibility identifiers to menu items and fix one incorrect one

  Halle

  committed
  8566be2

  Copy full SHA for 8566be2

• Add accessibilityIdentifier to more options find in page

  Halle

  committed
  c7163ea

  Copy full SHA for c7163ea

• Change in-use accessibilityIdentifier for optionsButton so it isn't an English phrase and update in test

  Halle

  committed
  6c98b35

  Copy full SHA for 6c98b35

• Find in page tests

  Halle

  committed
  d1e2190

  Copy full SHA for d1e2190

• Fix accessibilityIdentifiers for find in page text fields, add roles to disambiguate

  Halle

  committed
  1d36c57

  Copy full SHA for 1d36c57

• Test for number of search hits in page, single window enforecement, and cleanup

  Halle

  committed
  5d7ff4f

  Copy full SHA for 5d7ff4f

• Only deal with the HTML once in the test case run

  Halle

  committed
  067ea21

  Copy full SHA for 067ea21

Commits on Mar 15, 2024

• Merge branch 'main' into halle/find-in-page-tests

  Halle

  committed
  4e56b98

  Copy full SHA for 4e56b98

• Add waitForNonExistence XCUIElement extension to UI Tests Common

  Halle

  committed
  d5b4bf3

  Copy full SHA for d5b4bf3

• Add NSImage cropping to NSImageExtensions.swift

  Halle

  committed
  2b71d4e

  Copy full SHA for 2b71d4e

• Add extensions to UI Tests target

  Halle

  committed
  0599135

  Copy full SHA for 0599135

• Clean up tests and language

  Halle

  committed
  5e38ef9

  Copy full SHA for 5e38ef9

• Adds test to detect selected find result highlight color

  Halle

  committed
  956a6be

  Copy full SHA for 956a6be

• Merge branch 'main' into halle/find-in-page-tests

  Halle

  committed
  21b1d23

  Copy full SHA for 21b1d23

• Add two more accessibility identifiers to menus

  Halle

  committed
  cf26a1a

  Copy full SHA for cf26a1a

• Tests of find next, generalize screenshot color checking

  Halle

  committed
  bca6b11

  Copy full SHA for bca6b11

• Test cleanup

  Halle

  committed
  d25a6fb

  Copy full SHA for d25a6fb

• Formatting cleanup

  Halle

  committed
  0554d06

  Copy full SHA for 0554d06

Commits on Mar 18, 2024

• Test cleanup

  Halle

  committed
  3ca9266

  Copy full SHA for 3ca9266

• Merge branch 'main' into halle/find-in-page-tests

  Halle

  committed
  d706994

  Copy full SHA for d706994

• Fix line spaces

  Halle

  committed
  95c0651

  Copy full SHA for 95c0651

• XCTUnwrap in tests

  Halle

  committed
  72832d2

  Copy full SHA for 72832d2

• Space

  Halle

  committed
  61486c9

  Copy full SHA for 61486c9

• Clarify matchingPixels, and do all pixel operations in a single pass

  Halle

  committed
  2514a57

  Copy full SHA for 2514a57

• file URL nicer as property

  Halle

  committed
  77170cb

  Copy full SHA for 77170cb

Commits on Mar 19, 2024

• Merge branch 'main' into halle/find-in-page-tests

  Halle

  committed
  383d56d

  Copy full SHA for 383d56d

• Fix for header template warning

  Halle

  committed
  2869f9a

  Copy full SHA for 2869f9a

Commits on Mar 20, 2024

• Merge branch 'main' into halle/find-in-page-tests

  Halle

  committed
  e328b59

  Copy full SHA for e328b59

• Remove repeated XCUIApplication references

  Halle

  committed
  c346d2c

  Copy full SHA for c346d2c

• Cleanup and access modifiers

  Halle

  committed
  054316b

  Copy full SHA for 054316b

Commits on Mar 21, 2024

• Synchronize test styles across test cases

  Halle

  committed
  0a20250

  Copy full SHA for 0a20250

• Merge branch 'main' into halle/find-in-page-tests

  Halle

  committed
  ce811f8

  Copy full SHA for ce811f8

Commits on Mar 22, 2024

• Correct test names

  Halle

  committed
  c9cc0da

  Copy full SHA for c9cc0da

• Skip TabBarTests for ease of review

  Halle

  committed
  cf18721

  Copy full SHA for cf18721

• It is possible for selection coordinates to overlap

  Halle

  committed
  2334c28

  Copy full SHA for 2334c28

• Make comment truthful

  Halle

  committed
  059aa9a

  Copy full SHA for 059aa9a