Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Data Reporting for Chromium Keychain User Actions #2469

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented Mar 21, 2024

Task/Issue URL: https://app.asana.com/0/1206488453854252/1206886138223449/f

Description:

  • Stop firing an error Pixel when the user cancels Keychain password entry
  • Add new non-error pixel for user being prompted for Keychain password entry
    ** Name: m_mac_password_import_keychain_prompt
    ** Triggering condition: User selects ‘Import’ from a Chromium-based browser
    ** Parameter Names: None
    ** Why It’s Needed: To understand the rate at which users deny (see below Pixel) Keychain access, we need to compare ‘deny’ events to total number of keychain prompt events
  • Add new non-error pixel for user denying keychain access event
    ** Name: m_mac_password_import_keychain_prompt_denied
    ** Triggering condition: User denies access to their keychain
    ** Parameter Names: None
    ** Why It’s Needed: We want to understand the the rate at which users deny keychain access

Steps to test this PR:

  1. Run this code
  2. Choose to import from Chrome
  3. Confirm that the m_mac_password_import_keychain_prompt pixel is fired when the user is prompted to enter their keychain password
  4. Deny access to the keychain
  5. Confirm that the m_mac_password_import_keychain_prompt_denied pixel is fired when the user denies access to their keychain

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 21, 2024
@aataraxiaa aataraxiaa removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 21, 2024
@aataraxiaa aataraxiaa requested a review from amddg44 March 21, 2024 13:06
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@aataraxiaa aataraxiaa merged commit 18cbbda into main Mar 21, 2024
23 of 25 checks passed
@aataraxiaa aataraxiaa deleted the pete/improve-keychain-actions-data-reporting branch March 21, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants