Improve Data Reporting for Chromium Keychain User Actions #2469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206488453854252/1206886138223449/f
Description:
** Name:
m_mac_password_import_keychain_prompt
** Triggering condition: User selects ‘Import’ from a Chromium-based browser
** Parameter Names: None
** Why It’s Needed: To understand the rate at which users deny (see below Pixel) Keychain access, we need to compare ‘deny’ events to total number of keychain prompt events
** Name:
m_mac_password_import_keychain_prompt_denied
** Triggering condition: User denies access to their keychain
** Parameter Names: None
** Why It’s Needed: We want to understand the the rate at which users deny keychain access
Steps to test this PR:
m_mac_password_import_keychain_prompt
pixel is fired when the user is prompted to enter their keychain passwordm_mac_password_import_keychain_prompt_denied
pixel is fired when the user denies access to their keychain—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation