Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBP: Fix last and next scans UI #2471

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

jotaemepereira
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1204006570077678/1206854674919406/f
Tech Design URL:
CC:

Description:
This change fixes two things:

  • We were showing incorrect dates for brokers in the last scans list
  • We were showing the closest scans to today in the next scans. Now we show scans happening in a week range

Steps to test this PR:

  1. Run PIR with a profile
  2. Tap the card with scan information, check the information is correct with the database (Debug -> PIR -> Show DB)

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 21, 2024
@jotaemepereira jotaemepereira requested a review from Bunn March 21, 2024 14:17
Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comments

@github-actions github-actions bot removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 21, 2024
@jotaemepereira jotaemepereira merged commit 397a350 into main Mar 21, 2024
17 checks passed
@jotaemepereira jotaemepereira deleted the juan/dbp/fix-past-scans-date branch March 21, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants