Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription pixels refinements #2472

Merged
merged 7 commits into from
Mar 22, 2024
Merged

Subscription pixels refinements #2472

merged 7 commits into from
Mar 22, 2024

Conversation

federicocappelli
Copy link
Member

Task/Issue URL: https://app.asana.com/0/1205842942115003/1205469290776415/f

Description:

Most of the pixels for Subscription Pro tested and refined

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@federicocappelli federicocappelli requested review from miasma13, a team and alessandroboron and removed request for a team and miasma13 March 21, 2024 14:21
miasma13
miasma13 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. The only thing I am unsure is the firing of privacyProOfferScreenImpression which will trigger also for different subscription URLs in the base path.

@miasma13
Copy link
Contributor

Looks good

@federicocappelli federicocappelli merged commit 9c8a825 into main Mar 22, 2024
17 checks passed
@federicocappelli federicocappelli deleted the fcappelli/pixels_refinements branch March 22, 2024 08:58
samsymons added a commit that referenced this pull request Mar 22, 2024
@samsymons
Merge branch 'main' into sam/vpn-ship-review-problems
f4dd479 
* main:
  Bug fixed for subscription restore from app store (#2478)
  Subscription pixels refinements  (#2472)
  Adds VPN PrivacyPro pixels and ensure App Store runs all tests (#2468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miasma13 miasma13 miasma13 approved these changes

@alessandroboron alessandroboron Awaiting requested review from alessandroboron alessandroboron was automatically assigned from duckduckgo/apple-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@federicocappelli @miasma13