-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect extra metadata #2476
Merged
Merged
Collect extra metadata #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
github-actions
bot
added
the
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
label
Mar 21, 2024
quanganhdo
removed
the
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
label
Mar 21, 2024
github-actions
bot
added
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
and removed
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
labels
Mar 21, 2024
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good, though the Privacy Pro build is failing. Tbh, that build should be deleted any day now, but for the time being we should make sure it builds.
samsymons
added a commit
that referenced
this pull request
Mar 25, 2024
# By Michal Smaga (2) and others # Via GitHub * main: BSK update for Autofill Script performance improvements (#2481) Add source to dbp pixelkit setup (#2482) Send correct platform value for App Store purchase options (#2493) Close subscription tabs when subscription becomes inactive (#2492) DBP: Changes to weekly scanning pixel parameters (#2474) Add tests for DBP waitlist migration (#2464) Ship review improvements (#2488) Collect extra metadata (#2476) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206897550778460/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation