Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect extra metadata #2476

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Collect extra metadata #2476

merged 6 commits into from
Mar 25, 2024

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Mar 21, 2024

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 21, 2024
@quanganhdo quanganhdo removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 21, 2024
@github-actions github-actions bot added bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project and removed bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project labels Mar 21, 2024
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@quanganhdo quanganhdo requested a review from samsymons March 25, 2024 04:35
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good, though the Privacy Pro build is failing. Tbh, that build should be deleted any day now, but for the time being we should make sure it builds.

@quanganhdo quanganhdo merged commit 2091c49 into main Mar 25, 2024
17 checks passed
@quanganhdo quanganhdo deleted the anh/pp/add-metadata branch March 25, 2024 04:57
samsymons added a commit that referenced this pull request Mar 25, 2024
# By Michal Smaga (2) and others
# Via GitHub
* main:
  BSK update for Autofill Script performance improvements (#2481)
  Add source to dbp pixelkit setup (#2482)
  Send correct platform value for App Store purchase options (#2493)
  Close subscription tabs when subscription becomes inactive (#2492)
  DBP: Changes to weekly scanning pixel parameters (#2474)
  Add tests for DBP waitlist migration (#2464)
  Ship review improvements (#2488)
  Collect extra metadata (#2476)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants