DBP: Fix memory leak on WebViewHandler #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
jotaemepereira
commented
Mar 22, 2024
| @@ -186,7 +186,9 @@ extension DataBrokerOperation { | |||
| switch actionType { | |||
| case .click: | |||
| stageCalculator?.fireOptOutFillForm() | |||
| try? await webViewHandler?.waitForWebViewLoad(timeoutInSeconds: 30) | |||
| try? await webViewHandler?.waitForWebViewLoad() | |||
There was a problem hiding this comment.
@Bunn This is a collateral change of removing the timeout. We were doing similar for clicks, what I’m doing there now is waiting 10 seconds before tapping.
We will probably need the same retry function that is now on C-S-S with clicks, but because clicks are done in opt-out, I think it makes sense to do it after launch.
github-actions
bot
removed
the
bot: not in app board
Bunn
reviewed
Mar 22, 2024
| @@ -59,7 +59,11 @@ final class DataBrokerProtectionWebViewHandler: NSObject, WebViewHandler { | |||
| } | |||
|
|
|||
| func initializeWebView(showWebView: Bool) async { | |||
| webView = WebView(frame: CGRect(origin: .zero, size: CGSize(width: 1024, height: 1024)), configuration: webViewConfiguration) | |||
| guard let configuration = self.webViewConfiguration else { | |||
| return | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204006570077678/1206888925019546/f
Tech Design URL:
CC:
Description:
Removes the leaking
Task.sleeponWebViewHandlerwhich was causingThe operation couldn’t be completed. No space left on deviceSteps to test this PR:
The operation couldn’t be completed. No space left on deviceor weird scenarios happening.