Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the caching logic for subscription and entitlements #2485

Merged
merged 6 commits into from
Mar 22, 2024
Merged

Rework the caching logic for subscription and entitlements #2485

merged 6 commits into from
Mar 22, 2024

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Mar 22, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1200019156869587/1206909771441779/f

Description:

  • Change default staleness time interval for subscription and entitlement cache to 20min
  • When storing subscription in the cache use the date based on default interval or its date of renewalOrExpiry - whatever is earlier
  • Make the VPN code use cache and its logic for doing fetch if data is stale
  • On applicationDidBecomeActive refresh subscription details and entitlements
  • In the app rely on subscription details and entitlements based on cache logic (cached if still valid else fetch)
Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@miasma13 miasma13 mentioned this pull request Mar 22, 2024
Merged
@jotaemepereira jotaemepereira mentioned this pull request Mar 22, 2024
Merged
@miasma13 miasma13 merged commit c7cf61d into main Mar 22, 2024
21 checks passed
@miasma13 miasma13 deleted the michal/subs-and-ent-caching branch March 22, 2024 20:05
samsymons added a commit that referenced this pull request Mar 22, 2024
@samsymons
Merge branch 'main' into sam/vpn-ship-review-problems
91ce5c9 
* main:
  BrowserServicesKit bump to 129.1.4 (#2487)
  DBP: Fix memory leak on WebViewHandler (#2483)
  Invalidate user cache (#2486)
  Rework the caching logic for subscription and entitlements (#2485)
  Fix expiry prompt uninstall button selection state (#2475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicocappelli federicocappelli federicocappelli approved these changes

@samsymons samsymons samsymons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miasma13 @samsymons @federicocappelli