New daily pixel for history save failures #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
tomasstrba
requested review from
a team and
THISISDINOSAUR
and removed request for
a team
tomasstrba
removed
the
bot: not in app board
|
Nope, I'll add it to the menu today and let you know when it is ready for another review. |
|
@THISISDINOSAUR , I added the pixel and made sure it works as expected. It's ready for another review. If you don't see the |
This reverts commit f8a8371.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206920829163329/f
Description:
Adding new daily pixel for history save failures to better understand how many devices are affected by a potential issue
Steps to test this PR:
mainbranch, run the app and turn on the pixel logging: Debug -> Logging -> Pixeltom/history-pixelbranchEncryptedHistoryStore.swifton line 237 by addingreturn .failure(HistoryStoreError.savingFailed)(right after beginning of theinsertNewVisits(..)method)m.mac.debug.history.save.failed.dailyis only fired once on the first history save attempt. Any subsequent save failures only trigger should only triggerm.mac.debug.history.save.failedInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation