VPN screen improvements #2550
Merged
VPN screen improvements #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etp/screen-improvements
github-actions
bot
added
the
bot: not in app board
quanganhdo
removed
the
bot: not in app board
quanganhdo
commented
Apr 5, 2024
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Menu/StatusBarMenu.swift
Outdated
Show resolved
Hide resolved
...ProtectionMac/Sources/NetworkProtectionUI/Views/StatusView/NetworkProtectionStatusView.swift
Show resolved
Hide resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
quanganhdo
changed the title
samsymons
approved these changes
Apr 16, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1206942473732466/f Tech Design URL: CC: **Description**: Updates the location displayed on VPN screen **Steps to test this PR**: 1. Check the location section of the VPN screen 2. Make sure changing locations work
Task/Issue URL: https://app.asana.com/0/0/1206942473732464/f Tech Design URL: CC: **Description**: Adds the Data Volume item & reorder the menu items. **Steps to test this PR**: 1. Open the VPN screen on either the status bar or main browser 2. Check if data volume is correct 3. Also, verify the menu item ordering. Open DDG should go last. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
quanganhdo
changed the title
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Application/URLEventHandler.swift # DuckDuckGo/NavigationBar/View/NetPPopoverManagerMock.swift # DuckDuckGo/Windows/View/WindowControllersManager.swift
# Conflicts: # DuckDuckGo/HomePage/Model/HomePageContinueSetUpModel.swift
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206942473732463/f
Tech Design URL:
CC:
Description:
Updates the VPN screen header.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation