UI Tests: State Restoration #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n English phrase and update in test
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # UITests/BookmarksBarTests.swift
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # UITests/BookmarksAndFavoritesTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205717021705374/f
Tech Design URL:
CC:
Description: Adds a series of UI tests for State Restoration
Steps to test this PR:
StateRestorationTestsNote: If this builds a
reviewbuild that is treated as a first run on your system during every test (for instance, asking you where to put the application), please build and run the scheme once instead of running its tests, and go through the new app install first run steps once before running the tests, and answer any first install questions.UI Tests general guidelines for everyone:
xcresultbundle so it is possible to view what happened differently on your machine, even if it seems like the same failure as a previous failure (it may be subtly different). Please give its screenshots or screen recording a look first before sending, just to rule out one-off failure causes like an unrelated app unexpectedly throwing up an update helper (or something similar) in front of whereXCUITestis waiting for a UI element to exist.xcresultbundle will include a screen recording or screenshots, for your privacy, please consider things like your chats, calls, and open documents that you don't want to send to a contractor when you are running the tests.Thank you very much for your help!