Fix secure coding error #2604
Merged
Fix secure coding error #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
|
|
||
| public required init?(coder: NSCoder) { | ||
| oneTimeError = coder.decodeObject(forKey: NSSecureCodingKeys.oneTimeError) as? Error | ||
| operationErrors = coder.decodeObject(forKey: NSSecureCodingKeys.operationErrors) as? [Error] |
There was a problem hiding this comment.
I wonder if we should do something if these fail, but then also not sure if we can ever know since they're optional?
Would they ever fail? It feels like they shouldn't...
There was a problem hiding this comment.
See https://developer.apple.com/documentation/foundation/nssecurecoding
This bit specifically:
I've zero idea if this may break in some way... but if we want to adhere to secure coding strictly, we should decode using decodeObject(of:forKey).
THISISDINOSAUR
approved these changes
Apr 11, 2024
THISISDINOSAUR
removed
the
bot: not in app board
Bunn
commented
Apr 11, 2024
| oneTimeError = coder.decodeObject(forKey: NSSecureCodingKeys.oneTimeError) as? Error | ||
| operationErrors = coder.decodeObject(forKey: NSSecureCodingKeys.operationErrors) as? [Error] | ||
| oneTimeError = coder.decodeObject(of: NSError.self, forKey: NSSecureCodingKeys.oneTimeError) | ||
| operationErrors = coder.decodeArrayOfObjects(ofClass: NSError.self, forKey: NSSecureCodingKeys.operationErrors) |
diegoreymendez
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203581873609357/1207056719863102/f
Description:
Fix issue sending XPC messages on error
Steps to test this PR:
/Library/Group\ Containers/HKE973VLUW.com.duckduckgo.macos.browser.dbp*macos-browser/LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Scheduler/DataBrokerProtectionProcessor.swift
Line 64 in 4a45c4b
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation