Require device auth to be set in order to use Sync #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
approved these changes
Apr 15, 2024
diegoreymendez
pushed a commit
that referenced
this pull request
Apr 18, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1206876054968715/f Tech Design URL: CC: **Description**: Require device auth to be set in order to use Sync **Steps to test this PR**: Test by changing `LocalAuthenticationService.swift:28` to return false. When sync is not set up: * [x] Connecting with device should be protected. * [x] Setting sync for current device should be protected. * [x] Recovering data should be protected. When sync is set up: * [x] Connecting with device should be protected. * [x] Saving recovery code should be protected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206876054968715/f
Tech Design URL:
CC:
Description:
Require device auth to be set in order to use Sync
Steps to test this PR:
Test by changing
LocalAuthenticationService.swift:28to return false.When sync is not set up:
When sync is set up:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation