Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Test workflows MacOS 13 + 14 #2614

Merged
merged 2 commits into from
Apr 12, 2024
Merged

UI Test workflows MacOS 13 + 14 #2614

merged 2 commits into from
Apr 12, 2024

Conversation

kshann
Copy link
Contributor

@kshann kshann commented Apr 12, 2024

Task/Issue URL: https://app.asana.com/0/0/1205717523425891/f
Tech Design URL:
CC: @ayoy

Description:
13/14 flows from this PR #2515
Have left asana notifications commented out for now.

Steps to test this PR:

  1. Example run https://github.com/duckduckgo/macos-browser/actions/runs/8660861087
  2. If you want to run gh workflow run "ui_tests.yml" --ref "kieran/ui-tests-macos1314"

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@kshann kshann requested a review from ayoy April 12, 2024 11:19
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job @kshann!

@kshann kshann merged commit 670d54c into main Apr 12, 2024
23 checks passed
@kshann kshann deleted the kieran/ui-tests-macos1314 branch April 12, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants