-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WebView hanging input #2616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me pending CI getting back to a green state, looks like a recent commit broke some compilation, I tested before it was added though.
I'm no longer able to reproduce the bug (neither by using your provided changes, or when testing by hand), and I spent some time smoke testing other sites, including testing in a slow network environment via Network Link Conditioner, to make sure that we aren't introducing weird behaviour when the web view takes a long time to load.
I'll approve this, feel free to merge once it's green. Great work! Next step here is on me to try and get this happening in a standalone project that we can send to Apple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, new changes are working well 👍
I tested on regular conditions, poor networks, etc., tried to find a way to break webview interaction but couldn't, and the bug is gone in all of my testing. Nice work!
Task/Issue URL: https://app.asana.com/0/1177771139624306/1206990108527681/f
Description:
Steps to test this PR:
WindowControllersManager.swift.zip
❗️ that‘s it
appears in the log and verify mouse input is working, repeatInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation