prevent target=_blank links in duckplayer #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on |
github-actions
bot
added
the
bot: not in app board
shakyShane
commented
Apr 12, 2024
ayoy
reviewed
Apr 15, 2024
shakyShane
force-pushed
the
04-12-poc_prevent_target__blank_links_in_duckplayer
branch
from
1ef6021 to
f14e449
Compare
|
@mallexxx - I updated the PR as requested, could you give it a review please :) |
shakyShane
changed the title
github-actions
bot
removed
the
bot: not in app board
shakyShane
deleted the
04-12-poc_prevent_target__blank_links_in_duckplayer
branch
diegoreymendez
pushed a commit
that referenced
this pull request
Apr 18, 2024
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206957893781167/f Tech Design URL: CC: **Description**: The goal of this PR is to alter how URLs are handled within DuckPlayer, especially those opening in a new tab like video recommendations. Now, instead of being opened in a new tab, these URLs will be loaded within DuckPlayer itself. The changes mainly involve adding a new case 'preventTargetBlank' to the NavigationDecision enum and implementing it in decideNewWindowPolicy method in DuckPlayerTabExtension. **Steps to test this PR**: 1. watch a video in duck player 2. at the end, click a recommended link 3. it should load in the same tab <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) Co-authored-by: Shane Osbourne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206957893781167/f
Tech Design URL:
CC:
Description:
The goal of this PR is to alter how URLs are handled within DuckPlayer, especially those opening in a new tab like video recommendations. Now, instead of being opened in a new tab, these URLs will be loaded within DuckPlayer itself. The changes mainly involve adding a new case 'preventTargetBlank' to the NavigationDecision enum and implementing it in decideNewWindowPolicy method in DuckPlayerTabExtension.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation