[Release PR] Remove waitlist button state #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanganhdo
approved these changes
Apr 12, 2024
| if NetworkProtectionKeychainTokenStore().isFeatureActivated { | ||
| return .image(for: icon)! | ||
| } | ||
|
|
||
| return .image(for: icon)! |
There was a problem hiding this comment.
Looks sus, but it's going away anyway 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207061569597820/f
Tech Design URL:
CC:
Description:
This PR removes the waitlist available NetP icon to make sure it never shows to users again.
We don't need this asset at all any more so let's just remove it and no longer show the custom state. We'll come back later and properly clean up the waitlist UI code, this PR just does the bare minimum to fix the issue.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation