New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fireproofing option to Fire popover #2966

Draft

mallexxx wants to merge 1 commit into main from alex/fireproof-in-fire-popover

Collaborator

mallexxx commented Jul 12, 2024

Task/Issue URL: https://app.asana.com/0/1204517122485752/1205507100821092/f

Steps to test this PR:

Open new tab, open Fire popover, validate there‘s no fireproofing option
Open another tab, navigate to non-fireproofed website, validate there‘s fireproofing option
Fireproof, validate the button changes its state to Remove fireproofing
Open new tab, navigate to another website, open the popover
Hit cmd+w to close the tab, validate the button state changes
Hit cmd+w to get to the New Tab page, validate Fireproofing option disappears

Definition of Done:

Does this PR satisfy our Definition of Done?

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation


          Add fireproofing option to Fire popover

26078dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet