Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue sending the duckPlayerWatchOnYoutube pixel #3114

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix issue sending the duckPlayerWatchOnYoutube pixel #3114

merged 1 commit into from
Aug 19, 2024

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Aug 19, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1207252092703676/1208089112886056/f
Tech Design URL:
CC:

Description:
Fix issue sending the watch on youtube pixel

Steps to test this PR:

  1. Check settings, set open Duck Player in new tab to false
  2. Open a video in Duck Player, click in watch in youtube
  3. Check if the pixel duckPlayerWatchOnYoutube was fired
  4. Check settings, set open Duck Player in new tab to true
  5. Open a video in Duck Player, click in watch in youtube
  6. Check if the pixel duckPlayerWatchOnYoutube was fired

@Bunn Bunn requested a review from afterxleep August 19, 2024 13:32
@Bunn Bunn changed the title Fix issue sending the watch on youtube pixel Fix issue sending the duckPlayerWatchOnYoutube pixel Aug 19, 2024
@Bunn Bunn merged commit 8128f72 into main Aug 19, 2024
34 checks passed
@Bunn Bunn deleted the bunn/duckplayer/fix-pixel branch August 19, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afterxleep afterxleep afterxleep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @afterxleep